Fix of Deprecation warning with php 8.1 #614 #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
williamdes
reviewed
May 11, 2023
Co-authored-by: William Desportes <williamdes@wdes.fr>
|
Can anyone please review my commit. Thank you! |
Hey, it's been 3 days. Please be patient, we work as volunteers. And the repository author does reviews when it's possible. Nobody knows so we all just wait and make sure our code is polished |
|
Can you please edit your PR description to include |
Closed
nicolaasuni
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix of Deprecation warning with php 8.1 #614
Array key was expecting integer but float was being passed. Typecasting to int should fix this issue