Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation warning with php 8.1 #614

Open
abusohib opened this issue May 11, 2023 · 2 comments
Open

Deprecation warning with php 8.1 #614

abusohib opened this issue May 11, 2023 · 2 comments

Comments

@abusohib
Copy link

abusohib commented May 11, 2023 •
edited

[11-May-2023 09:46:40 Indian/Kerguelen] PHP Deprecated: Implicit conversion from float 0.5 to int loses precision in barcodes/qrcode.php on line 891

https://github.com/tecnickcom/TCPDF/blob/main/include/barcodes/qrcode.php#L891
@johnson361
Copy link
Contributor

$row =(int) $row;
Adding this line should convert the float value to integer just before $ret = $this->rsblocks[$row]['data'][$col];
on line 890

@johnson361 johnson361 mentioned this issue May 11, 2023
Merged
@williamdes williamdes mentioned this issue Aug 2, 2023
Closed
nicolaasuni pushed a commit that referenced this issue Sep 6, 2023
@johnson361 @rnallori @williamdes
Fix of Deprecation warning with php 8.1 #614 (#615)
7734617 
* Fix of Deprecation warning with php 8.1 #614

* Update include/barcodes/qrcode.php

Co-authored-by: William Desportes <williamdes@wdes.fr>

---------

Co-authored-by: Robert Johnson Nallori <rnallori@evoketechnologies.com>
Co-authored-by: johnson361 <johnson361@users.noreply.github.com>
Co-authored-by: William Desportes <williamdes@wdes.fr>
@williamdes
Copy link
Contributor

williamdes commented Sep 6, 2023 •
edited

Can you close this one please?
#615 was merged and 6.6.3 is out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@johnson361 @abusohib @williamdes