Remove RequireThisOnParentMethodCallRule, as not useful + remove unus…

…ed tests (#52)
symplify · May 19, 2023 · dd956d8 · dd956d8
1 parent a0967f0
commit dd956d8
Show file tree

Hide file tree

Showing 103 changed files with 15 additions and 2,264 deletions.
diff --git a/composer.json b/composer.json
@@ -21,7 +21,9 @@
         "symplify/easy-ci": "^11.2",
         "phpstan/extension-installer": "^1.3",
         "php-parallel-lint/php-parallel-lint": "^1.3",
-        "illuminate/console": "^10.9"
+        "illuminate/console": "^10.9",
+        "tomasvotruba/unused-public": "^0.1.10",
+        "tomasvotruba/type-coverage": "^0.2.0"
     },
     "autoload": {
         "psr-4": {

diff --git a/config/static-rules.neon b/config/static-rules.neon
@@ -29,7 +29,6 @@ rules:
     # explicit naming
     - Symplify\PHPStanRules\Rules\NoDefaultExceptionRule
     - Symplify\PHPStanRules\Rules\NoParentMethodCallOnNoOverrideProcessRule
-    - Symplify\PHPStanRules\Rules\RequireThisOnParentMethodCallRule
     - Symplify\PHPStanRules\Rules\RequireThisCallOnLocalMethodRule
     - Symplify\PHPStanRules\Rules\ForbiddenMultipleClassLikeInOneFileRule
 

diff --git a/docs/rules_overview.md b/docs/rules_overview.md
@@ -1,4 +1,4 @@
-# 88 Rules Overview
+# 87 Rules Overview
 
 ## AnnotateRegexClassConstWithRegexLinkRule
 
@@ -2964,54 +2964,6 @@ class SomeClass
 
 <br>
 
-## RequireThisOnParentMethodCallRule
-
-Use "$this-><method>()" instead of "parent::<method>()" unless in the same named method
-
-- class: [`Symplify\PHPStanRules\Rules\RequireThisOnParentMethodCallRule`](../src/Rules/RequireThisOnParentMethodCallRule.php)
-
-```php
-class SomeParentClass
-{
-    public function run()
-    {
-    }
-}
-
-class SomeClass extends SomeParentClass
-{
-    public function go()
-    {
-        parent::run();
-    }
-}
-```
-
-:x:
-
-<br>
-
-```php
-class SomeParentClass
-{
-    public function run()
-    {
-    }
-}
-
-class SomeClass extends SomeParentClass
-{
-    public function go()
-    {
-        $this->run();
-    }
-}
-```
-
-:+1:
-
-<br>
-
 ## RequireUniqueEnumConstantRule
 
 Enum constants "%s" are duplicated. Make them unique instead

diff --git a/...CognitiveComplexity/AstCognitiveComplexityAnalyzer/AstCognitiveComplexityAnalyzerTest.php b/...CognitiveComplexity/AstCognitiveComplexityAnalyzer/AstCognitiveComplexityAnalyzerTest.php
diff --git a/packages-tests/CognitiveComplexity/AstCognitiveComplexityAnalyzer/Source/function.php.inc b/packages-tests/CognitiveComplexity/AstCognitiveComplexityAnalyzer/Source/function.php.inc
diff --git a/packages-tests/CognitiveComplexity/AstCognitiveComplexityAnalyzer/Source/function2.php.inc b/packages-tests/CognitiveComplexity/AstCognitiveComplexityAnalyzer/Source/function2.php.inc
diff --git a/packages-tests/CognitiveComplexity/AstCognitiveComplexityAnalyzer/Source/function3.php.inc b/packages-tests/CognitiveComplexity/AstCognitiveComplexityAnalyzer/Source/function3.php.inc
diff --git a/packages-tests/CognitiveComplexity/AstCognitiveComplexityAnalyzer/Source/function4.php.inc b/packages-tests/CognitiveComplexity/AstCognitiveComplexityAnalyzer/Source/function4.php.inc
diff --git a/packages-tests/CognitiveComplexity/AstCognitiveComplexityAnalyzer/Source/function6.php.inc b/packages-tests/CognitiveComplexity/AstCognitiveComplexityAnalyzer/Source/function6.php.inc
diff --git a/packages-tests/CognitiveComplexity/AstCognitiveComplexityAnalyzer/Source/function7.php.inc b/packages-tests/CognitiveComplexity/AstCognitiveComplexityAnalyzer/Source/function7.php.inc
diff --git a/packages-tests/CognitiveComplexity/AstCognitiveComplexityAnalyzer/Source/function8.php.inc b/packages-tests/CognitiveComplexity/AstCognitiveComplexityAnalyzer/Source/function8.php.inc
diff --git a/...s-tests/CognitiveComplexity/AstCognitiveComplexityAnalyzer/config/configured_service.neon b/...s-tests/CognitiveComplexity/AstCognitiveComplexityAnalyzer/config/configured_service.neon
diff --git a/...eComplexity/CompositionOverInheritanceAnalyzer/CompositionOverInheritanceAnalyzerTest.php b/...eComplexity/CompositionOverInheritanceAnalyzer/CompositionOverInheritanceAnalyzerTest.php
diff --git a/packages-tests/CognitiveComplexity/CompositionOverInheritanceAnalyzer/Source/class.php.inc b/packages-tests/CognitiveComplexity/CompositionOverInheritanceAnalyzer/Source/class.php.inc
diff --git a/packages-tests/CognitiveComplexity/CompositionOverInheritanceAnalyzer/Source/class1.php.inc b/packages-tests/CognitiveComplexity/CompositionOverInheritanceAnalyzer/Source/class1.php.inc
diff --git a/packages-tests/CognitiveComplexity/CompositionOverInheritanceAnalyzer/Source/class2.php.inc b/packages-tests/CognitiveComplexity/CompositionOverInheritanceAnalyzer/Source/class2.php.inc
diff --git a/...sts/CognitiveComplexity/CompositionOverInheritanceAnalyzer/config/configured_service.neon b/...sts/CognitiveComplexity/CompositionOverInheritanceAnalyzer/config/configured_service.neon