[ObjectCalisthenics] Remove NoChainMethodCallRule, as more exceptions…

… than rules (#50)
symplify · May 17, 2023 · a0967f0 · a0967f0
1 parent 8317152
commit a0967f0
Show file tree

Hide file tree

Showing 19 changed files with 1 addition and 488 deletions.
diff --git a/config/code-complexity-rules.neon b/config/code-complexity-rules.neon
@@ -9,6 +9,5 @@ rules:
     - Symplify\PHPStanRules\Rules\Enum\RequireEnumDocBlockOnConstantListPassRule
     - Symplify\PHPStanRules\Rules\NoFuncCallInMethodCallRule
     - Symplify\PHPStanRules\Rules\NoDynamicNameRule
-    - Symplify\PHPStanRules\ObjectCalisthenics\Rules\NoChainMethodCallRule
     - Symplify\PHPStanRules\Rules\ForbiddenNestedCallInAssertMethodCallRule
     - Symplify\PHPStanRules\Rules\Explicit\NoRelativeFilePathRule
diff --git a/config/packages/object-calisthenics-rules/object-calisthenics-rules.neon b/config/packages/object-calisthenics-rules/object-calisthenics-rules.neon
@@ -5,6 +5,3 @@ services:
         arguments:
             minNameLength: 3
             allowedShortNames: ['id', 'to', 'up']
-
-rules:
-    - Symplify\PHPStanRules\ObjectCalisthenics\Rules\NoChainMethodCallRule
diff --git a/config/services/services.neon b/config/services/services.neon
@@ -18,7 +18,6 @@ services:
     - Symplify\PHPStanRules\Enum\EnumConstantAnalyzer
     - Symplify\PHPStanRules\Formatter\RequiredWithMessageFormatter
     - Symplify\PHPStanRules\Location\DirectoryChecker
-    - Symplify\PHPStanRules\Matcher\ObjectTypeMatcher
     - Symplify\PHPStanRules\Matcher\PositionMatcher
     - Symplify\PHPStanRules\Matcher\SharedNamePrefixMatcher
     - Symplify\PHPStanRules\Naming\BoolishNameAnalyser
@@ -57,8 +56,6 @@ services:
     - Symplify\PHPStanRules\Matcher\Collector\PublicClassMethodMatcher
     - Symplify\PHPStanRules\Matcher\ClassMethodCallReferenceResolver
     - Symplify\PHPStanRules\Printer\CollectorMetadataPrinter
-    - Symplify\PHPStanRules\NodeAnalyzer\MethodCall\AllowedChainCallSkipper
-
 
     -
         class: Symplify\PHPStanRules\NodeVisitor\AssignedToPropertyNodeVisitor

diff --git a/docs/rules_overview.md b/docs/rules_overview.md
@@ -1,4 +1,4 @@
-# 89 Rules Overview
+# 88 Rules Overview
 
 ## AnnotateRegexClassConstWithRegexLinkRule
 
@@ -1143,49 +1143,6 @@ class SomeClass
 
 <br>
 
-## NoChainMethodCallRule
-
-Do not use chained method calls. Put each on separated lines.
-
-:wrench: **configure it!**
-
-- class: [`Symplify\PHPStanRules\ObjectCalisthenics\Rules\NoChainMethodCallRule`](../packages/ObjectCalisthenics/Rules/NoChainMethodCallRule.php)
-
-```yaml
-services:
-    -
-        class: Symplify\PHPStanRules\ObjectCalisthenics\Rules\NoChainMethodCallRule
-        tags: [phpstan.rules.rule]
-        arguments:
-            allowedChainTypes:
-                - AllowedFluent
-```
-
-↓
-
-```php
-$this->runThis()->runThat();
-
-$fluentClass = new AllowedFluent();
-$fluentClass->one()->two();
-```
-
-:x:
-
-<br>
-
-```php
-$this->runThis();
-$this->runThat();
-
-$fluentClass = new AllowedFluent();
-$fluentClass->one()->two();
-```
-
-:+1:
-
-<br>
-
 ## NoConstructorInTestRule
 
 Do not use constructor in tests. Move to `setUp()` method

diff --git a/packages-tests/ObjectCalisthenics/Rules/NoChainMethodCallRule/Fixture/ChainMethodCall.php b/packages-tests/ObjectCalisthenics/Rules/NoChainMethodCallRule/Fixture/ChainMethodCall.php
diff --git a/...es-tests/ObjectCalisthenics/Rules/NoChainMethodCallRule/Fixture/SkipExtraAllowedClass.php b/...es-tests/ObjectCalisthenics/Rules/NoChainMethodCallRule/Fixture/SkipExtraAllowedClass.php
diff --git a/packages-tests/ObjectCalisthenics/Rules/NoChainMethodCallRule/Fixture/SkipMockFluent.php b/packages-tests/ObjectCalisthenics/Rules/NoChainMethodCallRule/Fixture/SkipMockFluent.php
diff --git a/packages-tests/ObjectCalisthenics/Rules/NoChainMethodCallRule/Fixture/SkipNullsafeCalls.php b/packages-tests/ObjectCalisthenics/Rules/NoChainMethodCallRule/Fixture/SkipNullsafeCalls.php
diff --git a/packages-tests/ObjectCalisthenics/Rules/NoChainMethodCallRule/Fixture/SkipSymfonyConfig.php b/packages-tests/ObjectCalisthenics/Rules/NoChainMethodCallRule/Fixture/SkipSymfonyConfig.php
diff --git a/packages-tests/ObjectCalisthenics/Rules/NoChainMethodCallRule/Fixture/SkipTrinaryLogic.php b/packages-tests/ObjectCalisthenics/Rules/NoChainMethodCallRule/Fixture/SkipTrinaryLogic.php
diff --git a/packages-tests/ObjectCalisthenics/Rules/NoChainMethodCallRule/NoChainMethodCallRuleTest.php b/packages-tests/ObjectCalisthenics/Rules/NoChainMethodCallRule/NoChainMethodCallRuleTest.php
diff --git a/packages-tests/ObjectCalisthenics/Rules/NoChainMethodCallRule/Source/FinalClassToMock.php b/packages-tests/ObjectCalisthenics/Rules/NoChainMethodCallRule/Source/FinalClassToMock.php
diff --git a/packages-tests/ObjectCalisthenics/Rules/NoChainMethodCallRule/Source/InterfaceToMock.php b/packages-tests/ObjectCalisthenics/Rules/NoChainMethodCallRule/Source/InterfaceToMock.php
diff --git a/packages-tests/ObjectCalisthenics/Rules/NoChainMethodCallRule/Source/SomeAllowedFluent.php b/packages-tests/ObjectCalisthenics/Rules/NoChainMethodCallRule/Source/SomeAllowedFluent.php
diff --git a/packages-tests/ObjectCalisthenics/Rules/NoChainMethodCallRule/config/standalone_rule.neon b/packages-tests/ObjectCalisthenics/Rules/NoChainMethodCallRule/config/standalone_rule.neon
diff --git a/packages/ObjectCalisthenics/Rules/NoChainMethodCallRule.php b/packages/ObjectCalisthenics/Rules/NoChainMethodCallRule.php