Remove ForbiddenTestsNamespaceOutsideTestsDirectoryRule as overly det…

…ailed
symplify · May 19, 2023 · caeb9cd · caeb9cd
1 parent 96b9ff3
commit caeb9cd
Show file tree

Hide file tree

Showing 6 changed files with 1 addition and 203 deletions.
diff --git a/docs/rules_overview.md b/docs/rules_overview.md
@@ -1,4 +1,4 @@
-# 83 Rules Overview
+# 82 Rules Overview
 
 ## AnnotateRegexClassConstWithRegexLinkRule
 
@@ -849,40 +849,6 @@ $message = sprintf('%s', $firstValue, $secondValue);
 
 <br>
 
-## ForbiddenTestsNamespaceOutsideTestsDirectoryRule
-
-"Tests" namespace can be only in "/tests" directory
-
-- class: [`Symplify\PHPStanRules\Rules\ForbiddenTestsNamespaceOutsideTestsDirectoryRule`](../src/Rules/ForbiddenTestsNamespaceOutsideTestsDirectoryRule.php)
-
-```php
-// file path: "src/SomeClass.php"
-
-namespace App\Tests;
-
-class SomeClass
-{
-}
-```
-
-:x:
-
-<br>
-
-```php
-// file path: "tests/SomeClass.php"
-
-namespace App\Tests;
-
-class SomeClass
-{
-}
-```
-
-:+1:
-
-<br>
-
 ## ForbiddenThisArgumentRule
 
 `$this` as argument is not allowed. Refactor method to service composition

diff --git a/src/Location/DirectoryChecker.php b/src/Location/DirectoryChecker.php
@@ -8,20 +8,6 @@
 
 final class DirectoryChecker
 {
-    /**
-     * @param string[] $directoryNames
-     */
-    public function isInDirectoryNames(Scope $scope, array $directoryNames): bool
-    {
-        foreach ($directoryNames as $directoryName) {
-            if ($this->isInDirectoryNamed($scope, $directoryName)) {
-                return true;
-            }
-        }
-
-        return false;
-    }
-
     public function isInDirectoryNamed(Scope $scope, string $directoryName): bool
     {
         $normalized = $this->normalizePath($directoryName);

diff --git a/src/Rules/ForbiddenTestsNamespaceOutsideTestsDirectoryRule.php b/src/Rules/ForbiddenTestsNamespaceOutsideTestsDirectoryRule.php
diff --git a/...ceOutsideTestsDirectoryRule/Fixture/tests/SkipTestsNamespaceInsideTestsDirectoryClass.php b/...ceOutsideTestsDirectoryRule/Fixture/tests/SkipTestsNamespaceInsideTestsDirectoryClass.php
diff --git a/...mespaceOutsideTestsDirectoryRule/ForbiddenTestsNamespaceOutsideTestsDirectoryRuleTest.php b/...mespaceOutsideTestsDirectoryRule/ForbiddenTestsNamespaceOutsideTestsDirectoryRuleTest.php
diff --git a/tests/Rules/ForbiddenTestsNamespaceOutsideTestsDirectoryRule/config/configured_rule.neon b/tests/Rules/ForbiddenTestsNamespaceOutsideTestsDirectoryRule/config/configured_rule.neon