Remove ForbiddenNestedCallInAssertMethodCallRule as overly detailed (#56

)
symplify · May 19, 2023 · 96b9ff3 · 96b9ff3
1 parent 1530865
commit 96b9ff3
Show file tree

Hide file tree

Showing 10 changed files with 1 addition and 291 deletions.
diff --git a/docs/rules_overview.md b/docs/rules_overview.md
@@ -1,4 +1,4 @@
-# 84 Rules Overview
+# 83 Rules Overview
 
 ## AnnotateRegexClassConstWithRegexLinkRule
 
@@ -720,45 +720,6 @@ return strlen('name');
 
 <br>
 
-## ForbiddenNestedCallInAssertMethodCallRule
-
-Decouple method call in assert to standalone line to make test core more readable
-
-- class: [`Symplify\PHPStanRules\Rules\ForbiddenNestedCallInAssertMethodCallRule`](../src/Rules/ForbiddenNestedCallInAssertMethodCallRule.php)
-
-```php
-use PHPUnit\Framework\TestCase;
-
-final class SomeClass extends TestCase
-{
-    public function test()
-    {
-        $this->assertSame('oooo', $this->someMethodCall());
-    }
-}
-```
-
-:x:
-
-<br>
-
-```php
-use PHPUnit\Framework\TestCase;
-
-final class SomeClass extends TestCase
-{
-    public function test()
-    {
-        $result = $this->someMethodCall();
-        $this->assertSame('oooo', $result);
-    }
-}
-```
-
-:+1:
-
-<br>
-
 ## ForbiddenNodeRule
 
 "%s" is forbidden to use

diff --git a/src/Rules/ForbiddenNestedCallInAssertMethodCallRule.php b/src/Rules/ForbiddenNestedCallInAssertMethodCallRule.php
diff --git a/tests/Rules/ForbiddenNestedCallInAssertMethodCallRule/Fixture/NestedAssertMethodCall.php b/tests/Rules/ForbiddenNestedCallInAssertMethodCallRule/Fixture/NestedAssertMethodCall.php
diff --git a/tests/Rules/ForbiddenNestedCallInAssertMethodCallRule/Fixture/SkipAssertNothing.php b/tests/Rules/ForbiddenNestedCallInAssertMethodCallRule/Fixture/SkipAssertNothing.php
diff --git a/tests/Rules/ForbiddenNestedCallInAssertMethodCallRule/Fixture/SkipAssertTrue.php b/tests/Rules/ForbiddenNestedCallInAssertMethodCallRule/Fixture/SkipAssertTrue.php
diff --git a/tests/Rules/ForbiddenNestedCallInAssertMethodCallRule/Fixture/SkipCleanAssert.php b/tests/Rules/ForbiddenNestedCallInAssertMethodCallRule/Fixture/SkipCleanAssert.php
diff --git a/tests/Rules/ForbiddenNestedCallInAssertMethodCallRule/Fixture/SkipSimpleGetter.php b/tests/Rules/ForbiddenNestedCallInAssertMethodCallRule/Fixture/SkipSimpleGetter.php
diff --git a/...rbiddenNestedCallInAssertMethodCallRule/ForbiddenNestedCallInAssertMethodCallRuleTest.php b/...rbiddenNestedCallInAssertMethodCallRule/ForbiddenNestedCallInAssertMethodCallRuleTest.php
diff --git a/tests/Rules/ForbiddenNestedCallInAssertMethodCallRule/Source/AnyOtherObject.php b/tests/Rules/ForbiddenNestedCallInAssertMethodCallRule/Source/AnyOtherObject.php
diff --git a/tests/Rules/ForbiddenNestedCallInAssertMethodCallRule/config/configured_rule.neon b/tests/Rules/ForbiddenNestedCallInAssertMethodCallRule/config/configured_rule.neon