Remove RequireThisCallOnLocalMethodRule, as not practical (#53)

symplify · May 19, 2023 · 1924a3f · 1924a3f
1 parent dd956d8
commit 1924a3f
Show file tree

Hide file tree

Showing 9 changed files with 1 addition and 291 deletions.
diff --git a/config/static-rules.neon b/config/static-rules.neon
@@ -29,7 +29,6 @@ rules:
     # explicit naming
     - Symplify\PHPStanRules\Rules\NoDefaultExceptionRule
     - Symplify\PHPStanRules\Rules\NoParentMethodCallOnNoOverrideProcessRule
-    - Symplify\PHPStanRules\Rules\RequireThisCallOnLocalMethodRule
     - Symplify\PHPStanRules\Rules\ForbiddenMultipleClassLikeInOneFileRule
 
     # comlexity

diff --git a/docs/rules_overview.md b/docs/rules_overview.md
@@ -1,4 +1,4 @@
-# 87 Rules Overview
+# 86 Rules Overview
 
 ## AnnotateRegexClassConstWithRegexLinkRule
 
@@ -2922,48 +2922,6 @@ final class IssueControl extends Control
 
 <br>
 
-## RequireThisCallOnLocalMethodRule
-
-Use "$this-><method>()" instead of "self::<method>()" to call local method
-
-- class: [`Symplify\PHPStanRules\Rules\RequireThisCallOnLocalMethodRule`](../src/Rules/RequireThisCallOnLocalMethodRule.php)
-
-```php
-class SomeClass
-{
-    public function run()
-    {
-        self::execute();
-    }
-
-    private function execute()
-    {
-    }
-}
-```
-
-:x:
-
-<br>
-
-```php
-class SomeClass
-{
-    public function run()
-    {
-        $this->execute();
-    }
-
-    private function execute()
-    {
-    }
-}
-```
-
-:+1:
-
-<br>
-
 ## RequireUniqueEnumConstantRule
 
 Enum constants "%s" are duplicated. Make them unique instead

diff --git a/src/Rules/RequireThisCallOnLocalMethodRule.php b/src/Rules/RequireThisCallOnLocalMethodRule.php
diff --git a/tests/Rules/RequireThisCallOnLocalMethodRule/Fixture/CallLocalMethod.php b/tests/Rules/RequireThisCallOnLocalMethodRule/Fixture/CallLocalMethod.php
diff --git a/tests/Rules/RequireThisCallOnLocalMethodRule/Fixture/ParentClass.php b/tests/Rules/RequireThisCallOnLocalMethodRule/Fixture/ParentClass.php
diff --git a/tests/Rules/RequireThisCallOnLocalMethodRule/Fixture/SkipCallLocalStaticMethod.php b/tests/Rules/RequireThisCallOnLocalMethodRule/Fixture/SkipCallLocalStaticMethod.php
diff --git a/tests/Rules/RequireThisCallOnLocalMethodRule/Fixture/SkipCallParentMethodStatically.php b/tests/Rules/RequireThisCallOnLocalMethodRule/Fixture/SkipCallParentMethodStatically.php
diff --git a/tests/Rules/RequireThisCallOnLocalMethodRule/RequireThisCallOnLocalMethodRuleTest.php b/tests/Rules/RequireThisCallOnLocalMethodRule/RequireThisCallOnLocalMethodRuleTest.php
diff --git a/tests/Rules/RequireThisCallOnLocalMethodRule/config/configured_rule.neon b/tests/Rules/RequireThisCallOnLocalMethodRule/config/configured_rule.neon