[DoctrineBridge] add missing UPGRADE notes for #50689 and update tests #50699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Jun 21, 2023
|
Thank you @alli83. |
nicolas-grekas
added a commit
that referenced
this pull request
Jun 26, 2023
…eDatabase arg… (alli83) This PR was merged into the 6.3 branch. Discussion ---------- [DoctrineBridge] add missing changelog mention for isSameDatabase arg… | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | $isSameDatabase parameter was introduced in #48059. It has been added in order to know whether the database used by doctrine is the same as the one used by the component when integrating the latter with doctrine migrations. Also related to #50699 (UPGRADE mention) and #50689 Commits ------- 208861a [DoctrineBridge] add missing changelog mention for isSameDatabase arg introduced in #48059
nicolas-grekas
added a commit
that referenced
this pull request
Jun 28, 2023
… $isSameDatabase to configureSchema() methods (alli83) This PR was merged into the 7.0 branch. Discussion ---------- [Cache][DoctrineBridge][Lock][Messenger] Add parameter $isSameDatabase to configureSchema() methods | Q | A | ------------- | --- | Branch? | 7.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | $isSameDatabase parameter was introduced in #48059. This PR aims to remove BC layer on configureSchema method and $isSameDatabase parameter This parameter has been added in UPGRADE-6.3 in #50699 Commits ------- 7a8a8bf [DoctrineBridge]rm BC layer configureSchema check database
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$isSameDatabaseparameter was introduced in #48059. It has been added in order to know whether the database used by doctrine is the same as the one used by the component when integrating the latter with doctrine migrations.Also related to #50689