Skip to content

Commit

Permalink
minor #50699 [DoctrineBridge] add missing UPGRADE notes for #50689 an…
Browse files Browse the repository at this point in the history
…d update tests (alli83)

This PR was merged into the 6.3 branch.

Discussion
----------

[DoctrineBridge] add missing UPGRADE notes for #50689 and update tests

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | no
| New feature?  | no
| Deprecations? | yes
| Tickets       |
| License       | MIT
| Doc PR        |

`$isSameDatabase` parameter was introduced in #48059. It has been added in order to know whether the database used by doctrine is the same as the one used by the component when integrating the latter with doctrine migrations.

Also related to #50689

Commits
-------

5d2817d [DoctrineBridge] add missing UPGRADE notes for #50689
  • Loading branch information
nicolas-grekas committed Jun 21, 2023
2 parents 43c8bde + 5d2817d commit 8648df5
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 4 deletions.
7 changes: 7 additions & 0 deletions UPGRADE-6.3.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
UPGRADE FROM 6.2 to 6.3
=======================

Cache
-----

* `DoctrineDbalAdapter` now takes an optional `$isSameDatabase` parameter

Console
-------

Expand All @@ -22,6 +27,8 @@ DoctrineBridge
* Deprecate `DoctrineDbalCacheAdapterSchemaSubscriber` in favor of `DoctrineDbalCacheAdapterSchemaListener`
* Deprecate `MessengerTransportDoctrineSchemaSubscriber` in favor of `MessengerTransportDoctrineSchemaListener`
* Deprecate `RememberMeTokenProviderDoctrineSchemaSubscriber` in favor of `RememberMeTokenProviderDoctrineSchemaListener`
* `DoctrineTransport` now takes an optional `$isSameDatabase` parameter
* `DoctrineTokenProvider` now takes an optional `$isSameDatabase` parameter

Form
----
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public function testPostGenerateSchema()
$dbalAdapter = $this->createMock(DoctrineDbalAdapter::class);
$dbalAdapter->expects($this->once())
->method('configureSchema')
->with($schema, $dbalConnection);
->with($schema, $dbalConnection, fn () => true);

$subscriber = new DoctrineDbalCacheAdapterSchemaListener([$dbalAdapter]);
$subscriber->postGenerateSchema($event);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public function testPostGenerateSchema()
$doctrineTransport = $this->createMock(DoctrineTransport::class);
$doctrineTransport->expects($this->once())
->method('configureSchema')
->with($schema, $dbalConnection);
->with($schema, $dbalConnection, fn () => true);
$otherTransport = $this->createMock(TransportInterface::class);
$otherTransport->expects($this->never())
->method($this->anything());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,9 @@ public function testConfigureSchema()

$connection->expects($this->once())
->method('configureSchema')
->with($schema, $dbalConnection);
->with($schema, $dbalConnection, static fn () => true);

$transport->configureSchema($schema, $dbalConnection);
$transport->configureSchema($schema, $dbalConnection, static fn () => true);
}

private function getTransport(SerializerInterface $serializer = null, Connection $connection = null): DoctrineTransport
Expand Down

0 comments on commit 8648df5

Please sign in to comment.