Minor fixes around parse_url() checks
#58627
Merged
+14
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
changed the title
parse_url() checks
alexandre-daubois
approved these changes
Oct 22, 2024
xabbuh
reviewed
Oct 22, 2024
xabbuh
reviewed
Oct 22, 2024
nicolas-grekas
force-pushed
the
parse-url
branch
from
94f56bf to
1866ba2
Compare
xabbuh
approved these changes
Oct 22, 2024
chalasr
approved these changes
Oct 22, 2024
This was referenced Oct 27, 2024
Merged
Merged
Merged
github-merge-queue bot
pushed a commit
to Lendable/composer-license-checker
that referenced
this pull request
Oct 30, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [phpstan/phpstan](https://redirect.github.com/phpstan/phpstan) | `1.12.6` -> `1.12.7` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [phpunit/phpunit](https://phpunit.de/) ([source](https://redirect.github.com/sebastianbergmann/phpunit)) | `11.4.1` -> `11.4.3` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [rector/rector](https://getrector.org) ([source](https://redirect.github.com/rectorphp/rector)) | `1.2.6` -> `1.2.8` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [symfony/filesystem](https://symfony.com) ([source](https://redirect.github.com/symfony/filesystem)) | `6.4.12` -> `6.4.13` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>phpstan/phpstan (phpstan/phpstan)</summary> ### [`v1.12.7`](https://redirect.github.com/phpstan/phpstan/releases/tag/1.12.7) [Compare Source](https://redirect.github.com/phpstan/phpstan/compare/1.12.6...1.12.7) # Major new features 🚀 - **Implement template default types** ([#​3457](https://redirect.github.com/phpstan/phpstan-src/pull/3457)), [#​4801](https://redirect.github.com/phpstan/phpstan/issues/4801), thanks [@​jiripudil](https://redirect.github.com/jiripudil)! - See https://x.com/OndrejMirtes/status/1843920480342057154 # Improvements 🔧 - Move result cache output from debug (`-vvv`) to very verbose (`-vv`) mode ([#​3345](https://redirect.github.com/phpstan/phpstan-src/pull/3345)), thanks [@​janedbal](https://redirect.github.com/janedbal)! - Support for `non-empty-array` and `non-empty-list` array shape kind (phpstan/phpstan-src@107a7e3) - Improve lowercase string verbosity level ([#​3567](https://redirect.github.com/phpstan/phpstan-src/pull/3567)), thanks [@​VincentLanglet](https://redirect.github.com/VincentLanglet)! - Show TypeResult reasons in StrictComparisonOfDifferentTypesRule (phpstan/phpstan-src@34bacd7) - Decorate reasons when comparing ConstantArrayType (phpstan/phpstan-src@dc5d8f4), [#​11799](https://redirect.github.com/phpstan/phpstan/issues/11799), [#​10421](https://redirect.github.com/phpstan/phpstan/issues/10421) # Bugfixes 🐛 - Fix nextAutoIndexes in array coming from ArrayCombineFunctionReturnTypeExtension (phpstan/phpstan-src@c4ba434), [#​11819](https://redirect.github.com/phpstan/phpstan/issues/11819) - Fix return type of `array_reverse()` with optional keys ([#​3406](https://redirect.github.com/phpstan/phpstan-src/pull/3406)), [#​11549](https://redirect.github.com/phpstan/phpstan/issues/11549), thanks [@​herndlm](https://redirect.github.com/herndlm)! - Try to quit the child process only after internal errors were accounted for (phpstan/phpstan-src@dcd69eb), [#​11826](https://redirect.github.com/phpstan/phpstan/issues/11826) - react/http PHP 8.4 patch (phpstan/phpstan-src@40e461d) # Function signature fixes 🤖 - functionMap: more precise `get_defined_vars()` ([#​3546](https://redirect.github.com/phpstan/phpstan-src/pull/3546)), thanks [@​janedbal](https://redirect.github.com/janedbal)! - Reflection `getAttributes` returns `list` ([#​3548](https://redirect.github.com/phpstan/phpstan-src/pull/3548)), thanks [@​ManuelHu](https://redirect.github.com/ManuelHu)! - More precise md5/sha1 return type ([#​3541](https://redirect.github.com/phpstan/phpstan-src/pull/3541)), thanks [@​staabm](https://redirect.github.com/staabm)! - Improve return type of token_name() and PhpToken::getTokenName() ([#​3558](https://redirect.github.com/phpstan/phpstan-src/pull/3558)), [#​11808](https://redirect.github.com/phpstan/phpstan/issues/11808), thanks [@​zonuexe](https://redirect.github.com/zonuexe)! # Internals 🔍 - Fix typo (phpstan/phpstan-src@5b43d50) - Introduce isSuperTypeOfWithReason ([#​3538](https://redirect.github.com/phpstan/phpstan-src/pull/3538)), thanks [@​VincentLanglet](https://redirect.github.com/VincentLanglet)! - Add function `PHPStan\dumpPhpDocType()` ([#​3559](https://redirect.github.com/phpstan/phpstan-src/pull/3559)), [#​11561](https://redirect.github.com/phpstan/phpstan/issues/11561), thanks [@​zonuexe](https://redirect.github.com/zonuexe)! - Introduce TypeResult (phpstan/phpstan-src@a815d57) </details> <details> <summary>sebastianbergmann/phpunit (phpunit/phpunit)</summary> ### [`v11.4.3`](https://redirect.github.com/sebastianbergmann/phpunit/releases/tag/11.4.3): PHPUnit 11.4.3 [Compare Source](https://redirect.github.com/sebastianbergmann/phpunit/compare/11.4.2...11.4.3) ##### Changed - [#​6010](https://redirect.github.com/sebastianbergmann/phpunit/pull/6010): Improve parameter name for `assertGreaterThan()`, `assertGreaterThanOrEqual()`, `assertLessThan()`, and `assertLessThanOrEqual()` - [#​6012](https://redirect.github.com/sebastianbergmann/phpunit/pull/6012): Remove empty lines between TeamCity events ##### Fixed - [#​6017](https://redirect.github.com/sebastianbergmann/phpunit/pull/6017): Deprecation Triggers are not registered when Process Isolation is used *** [How to install or update PHPUnit](https://docs.phpunit.de/en/11.4/installation.html) ### [`v11.4.2`](https://redirect.github.com/sebastianbergmann/phpunit/releases/tag/11.4.2): PHPUnit 11.4.2 [Compare Source](https://redirect.github.com/sebastianbergmann/phpunit/compare/11.4.1...11.4.2) ##### Changed - [#​5989](https://redirect.github.com/sebastianbergmann/phpunit/pull/5989): Disable Xdebug in subprocesses when it is not used ##### Fixed - [#​5844](https://redirect.github.com/sebastianbergmann/phpunit/issues/5844): Error handlers that are not callable outside the scope they were registered in are not handled correctly - [#​5982](https://redirect.github.com/sebastianbergmann/phpunit/pull/5982): Typo in exception message *** [How to install or update PHPUnit](https://docs.phpunit.de/en/11.4/installation.html) </details> <details> <summary>rectorphp/rector (rector/rector)</summary> ### [`v1.2.8`](https://redirect.github.com/rectorphp/rector/releases/tag/1.2.8): Released Rector 1.2.8 [Compare Source](https://redirect.github.com/rectorphp/rector/compare/1.2.7...1.2.8) #### Bugfixes 🐛 - \[UnusedImport] Fix removing multiple uses ([#​6376](https://redirect.github.com/rectorphp/rector-src/pull/6376)), Thanks [@​jorgsowa](https://redirect.github.com/jorgsowa)! - \[PostRector] Clean up variables and conditional usage on UnusedImportRemovingPostRector ([#​6378](https://redirect.github.com/rectorphp/rector-src/pull/6378)) - \[PostRector] Reduce repetitive toString() on loop on UnusedImportRemovingPostRector ([#​6379](https://redirect.github.com/rectorphp/rector-src/pull/6379)) - \[CodeQuality] Skip no @​ property doc on DynamicDocBlockPropertyToNativePropertyRector ([#​6380](https://redirect.github.com/rectorphp/rector-src/pull/6380)) - \[CodeQuality] Handle with other attributes on DynamicDocBlockPropertyToNativePropertyRector ([#​6381](https://redirect.github.com/rectorphp/rector-src/pull/6381)) - \[CodeQuality] Use existing PhpAttributeAnalyzer service instead of AttributeFinder from Doctrine package on DynamicDocBlockPropertyToNativePropertyRector ([#​6382](https://redirect.github.com/rectorphp/rector-src/pull/6382)) - Fix duplicated register ContinueToBreakInSwitchRector in php52.php and php73.php ([#​6385](https://redirect.github.com/rectorphp/rector-src/pull/6385)) - \[AutoImport] Fix missing @​ in deep annotation auto import ([#​6386](https://redirect.github.com/rectorphp/rector-src/pull/6386)) - \[DeadCode] Skip non FullyQualified property type on RemoveTypedPropertyNonMockDocblockRector ([#​6383](https://redirect.github.com/rectorphp/rector-src/pull/6383)) <br> #### New Features 🥳 - \[CodeQuality] Add DynamicDocBlockPropertyToNativePropertyRector ([#​5691](https://redirect.github.com/rectorphp/rector-src/pull/5691)) - \[DX] \[Experimental] Add withPhpLevel() to raise PHP level one rule at a time ([#​6261](https://redirect.github.com/rectorphp/rector-src/pull/6261)) ### [`v1.2.7`](https://redirect.github.com/rectorphp/rector/releases/tag/1.2.7): Released Rector 1.2.7 [Compare Source](https://redirect.github.com/rectorphp/rector/compare/1.2.6...1.2.7) #### New Features 🥳 - Apply AddOverrideAttributeToOverriddenMethodsRector to traits ([#​6367](https://redirect.github.com/rectorphp/rector-src/pull/6367)), Thanks [@​jrjohnson](https://redirect.github.com/jrjohnson)! - \[Transform] MethodCall to New ([#​6352](https://redirect.github.com/rectorphp/rector-src/pull/6352)), Thanks [@​peterfox](https://redirect.github.com/peterfox)! - Add RemoveTypedPropertyNonMockDocblockRector ([#​6306](https://redirect.github.com/rectorphp/rector-src/pull/6306)) - \[DX] Add links to open the editor to the names of processed files and the names of rules applied ([#​6272](https://redirect.github.com/rectorphp/rector-src/pull/6272)), Thanks [@​carlos-granados](https://redirect.github.com/carlos-granados)! <br> #### Bugfixes 🐛 - Fixed --memory-limit=-1 option handling when used in parallel ([#​6349](https://redirect.github.com/rectorphp/rector-src/pull/6349)), Thanks [@​ddegasperi](https://redirect.github.com/ddegasperi)! - \[Php70] Fix delimiter in the middle on EregToPregMatchRector ([#​6356](https://redirect.github.com/rectorphp/rector-src/pull/6356)) - \[Php70] More delimiter case in the middle fix on EregToPregMatchRector ([#​6357](https://redirect.github.com/rectorphp/rector-src/pull/6357)) - \[Php80] Cast string/int for int vs string condition and case condition on ChangeSwitchToMatchRector ([#​6359](https://redirect.github.com/rectorphp/rector-src/pull/6359)) - \[DeadCode] Skip from call with return docblock on ReduceAlwaysFalseIfOrRector ([#​6361](https://redirect.github.com/rectorphp/rector-src/pull/6361)) - \[TypeDeclaration] Closure Param Types from Iterator Source ([#​6345](https://redirect.github.com/rectorphp/rector-src/pull/6345)), Thanks [@​peterfox](https://redirect.github.com/peterfox)! - \[Privatization] Allow privatize protected promoted property on PrivatizeFinalClassPropertyRector ([#​6360](https://redirect.github.com/rectorphp/rector-src/pull/6360)) - \[DeadCode] Skip with Else and ElseIf on SimplifyIfNotNullReturnRector ([#​6365](https://redirect.github.com/rectorphp/rector-src/pull/6365)) - \[Php70] Handle empty branch crash on unprintable char \x0C on EregToPregMatchRector ([#​6368](https://redirect.github.com/rectorphp/rector-src/pull/6368)) - \[UnusedImport] Different letter case for classes + optimization ([#​6362](https://redirect.github.com/rectorphp/rector-src/pull/6362)), Thanks [@​jorgsowa](https://redirect.github.com/jorgsowa)! - \[CodeQuality] Skip else indirect return on SimplifyIfReturnBoolRector ([#​6371](https://redirect.github.com/rectorphp/rector-src/pull/6371)) - \[CodeQuality] Clean up else check on SimplifyIfReturnBoolRector ([#​6372](https://redirect.github.com/rectorphp/rector-src/pull/6372)) - \[TypeDeclaration] Fix deep nested array docblock with \ prefix on ReturnTypeFromStrictNewArrayRector ([#​6373](https://redirect.github.com/rectorphp/rector-src/pull/6373)) - \[EarlyReturn] Skip nested with OR in root if statement condition on ChangeNestedForeachIfsToEarlyContinueRector ([#​6375](https://redirect.github.com/rectorphp/rector-src/pull/6375)) - \[DeadCode] Skip RemoveUnusedPrivatePropertyRector in middle assign ([#​6363](https://redirect.github.com/rectorphp/rector-src/pull/6363)) <br> #### Removed 💀 - \[NodeAnalyzer] Remove ClassAnalyzer::isAnonymousClassName() ([#​6351](https://redirect.github.com/rectorphp/rector-src/pull/6351)) - \[NodeAnalyzer] Remove unused AstResolver on VariadicAnalyzer ([#​6353](https://redirect.github.com/rectorphp/rector-src/pull/6353)) - \[DeadCode] Clean up double private method filtering on RemoveUnusedPrivateMethodRector ([#​6364](https://redirect.github.com/rectorphp/rector-src/pull/6364)) - \[DeadCode] Skip union docblock param with is_object() native type check on RemoveAlwaysTrueIfConditionRector ([#​6370](https://redirect.github.com/rectorphp/rector-src/pull/6370)) <br> *** <br> #### rectorphp/rector-symfony 🎵 - \[CodeQuality] Add AddTraitGetterReturnTypeBasedOnSetterRequiredRector ([#​671](https://redirect.github.com/rectorphp/rector-symfony/pull/671)) <br> #### rectorphp/rector-phpunit 🟢 - \[PHPUnit 10] Add ifs as default way for withConsecutive, as more readable and opens upgrade during PHPUnit 9 ([#​382](https://redirect.github.com/rectorphp/rector-phpunit/pull/382)) - Use simple direct assert on consecutive in case of arrow function in callable ([#​381](https://redirect.github.com/rectorphp/rector-phpunit/pull/381)) - Use more readable ifs on will return in WithConsecutiveRector ([#​380](https://redirect.github.com/rectorphp/rector-phpunit/pull/380)) - add NarrowSingleWillReturnCallbackRector to code quality set ([#​379](https://redirect.github.com/rectorphp/rector-phpunit/pull/379)) </details> <details> <summary>symfony/filesystem (symfony/filesystem)</summary> ### [`v6.4.13`](https://redirect.github.com/symfony/filesystem/releases/tag/v6.4.13) [Compare Source](https://redirect.github.com/symfony/filesystem/compare/v6.4.12...v6.4.13) **Changelog** (symfony/filesystem@v6.4.12...v6.4.13) - bug [symfony/symfony#58627](https://redirect.github.com/symfony/symfony/issues/58627) Minor fixes around `parse_url()` checks (@​nicolas-grekas) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/Lendable/composer-license-checker). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xMTUuMSIsInVwZGF0ZWRJblZlciI6IjM4LjEzMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those are all minor but some can still lead to edge-case bugs.