Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty lines between TeamCity events #6012

Closed

Conversation

smirok
Copy link
Contributor

@smirok smirok commented Oct 23, 2024

Hi, PhpStorm is here!

TeamCity output support was introduced on #1858. We have a workaround that allows us to cut such lines out. However, it's better for our internal events processing to avoid empty lines between teamcity events.

@sebastianbergmann sebastianbergmann self-assigned this Oct 23, 2024
@sebastianbergmann sebastianbergmann added the feature/teamcity The TeamCity logger label Oct 23, 2024
@smirok
Copy link
Contributor Author

smirok commented Oct 23, 2024

Fixed CS in the last commit

@sebastianbergmann sebastianbergmann changed the title Remove empty lines between teamcity events Remove empty lines between TeamCity events Oct 23, 2024
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.73%. Comparing base (0562f48) to head (02e5220).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6012   +/-   ##
=========================================
  Coverage     94.73%   94.73%           
  Complexity     6439     6439           
=========================================
  Files           697      697           
  Lines         20252    20252           
=========================================
  Hits          19185    19185           
  Misses         1067     1067           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sebastianbergmann
Copy link
Owner

Cherry-picked into 10.5 and merged to 11.4, 11.5, and main from there. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/teamcity The TeamCity logger
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants