[Validator] Update Type constraint, add number, finite-float and finite-number validations
#18527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillaume-a
force-pushed
the
50782
branch
2 times, most recently
from
6e07c22
to
74c74b7
Compare
|
This PR should fix CI / Build : #18529 |
|
IsFinite != Finite |
guillaume-a
changed the title
|
@OskarStark you're right, I renamed the Validator |
fabpot
requested changes
Jul 30, 2023
reference/constraints/IsFinite.rst
Outdated
| IsFinite | ||
| ======== | ||
|
|
||
| Validates that a value is a legal finite number. |
There was a problem hiding this comment.
Suggested change
| Validates that a value is a legal finite number. | |
| Validates that a value is a valid finite number. |
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Jul 30, 2023
…inite-float` and `finite-number` validations (guillaume-a) This PR was merged into the 6.4 branch. Discussion ---------- [Validator] Update `Type` constraint, add `number`, `finite-float` and `finite-number` validations | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix #50782 | License | MIT | Doc PR | symfony/symfony-docs#18527 Contraint `Type(['float'])` can produce positives with INF or NAN. This new types car narrow validation and limit validation to finite numbers. ``` #[Assert\Type(['int', 'finite-float'])] private $value; ``` Thank you for helping me with this one. Commits ------- c3b5709 [Validator] Update `Type` constraint, add `number`, `finite-float` and `finite-number` validations
symfony-splitter
pushed a commit
to symfony/validator
that referenced
this pull request
Jul 30, 2023
…inite-float` and `finite-number` validations (guillaume-a) This PR was merged into the 6.4 branch. Discussion ---------- [Validator] Update `Type` constraint, add `number`, `finite-float` and `finite-number` validations | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix #50782 | License | MIT | Doc PR | symfony/symfony-docs#18527 Contraint `Type(['float'])` can produce positives with INF or NAN. This new types car narrow validation and limit validation to finite numbers. ``` #[Assert\Type(['int', 'finite-float'])] private $value; ``` Thank you for helping me with this one. Commits ------- c3b5709560 [Validator] Update `Type` constraint, add `number`, `finite-float` and `finite-number` validations
guillaume-a
changed the title
Type constraint, add number, finite-float and finite-number validations
|
I've re write the doc according to all changes done in the initial ticket. |
OskarStark
reviewed
Jul 31, 2023
…d `finite-number` validations
|
Thank you Guillaume. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation for PR
Typeconstraint, addnumber,finite-floatandfinite-numbervalidations symfony#50907Related to
Typeconstraint considersNANandINFas floats symfony#50782This is my first sf-docs PR, please tell me if I did anything wrong.
Thank you.