Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve setup of default export and remove svelte/ssr #8516

Merged
merged 12 commits into from May 5, 2023

Conversation

benmccann
Copy link
Member

@benmccann benmccann commented Apr 18, 2023

I removed svelte/ssr, which will require vite-plugin-svelte 2.1.1. See sveltejs/vite-plugin-svelte#622 for the main PR there, which was released in 2.1.0 (minor bug fix came out in 2.1.1)

@vercel
Copy link

vercel bot commented Apr 18, 2023

@benmccann is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

@benmccann benmccann added this to the 4.x milestone Apr 18, 2023
@benmccann benmccann changed the title fix: improve setup of default export fix: improve setup of default export and remove svelte/ssr Apr 19, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@dummdidumm
Copy link
Member

For future self:

svelte/ssr was added due to #6372 but only vite-plugin-svelte ever used it, because soon after we discovered that an export condition does the same (#6743). So it's safe to remove in Svelte 4 because it's highly unlikely anyone depends on this (at least not our Rollup/Webpack plugins)

rollup.config.mjs Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants