In examples, add "svelte" to conditions
in esbuild build options
#183
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, when you try to import a svelte component library, you get the below error when building.
Steps to reproduce:
npx degit EMH333/esbuild-svelte/example-ts my-svelte-app
npm install svelte-french-toast
import toast from "svelte-french-toast"
to code.npm install
,npm run build
Solution
The solution is to add
conditions: ["svelte"],
to esbuild's build options. I had problem figuring it out as I couldn't find this information anywhere. So I added this information to examples in README and example projects.Svelte plugins for other bundlers like rollup and webpack all state this information in their READMEs:
https://github.com/sveltejs/rollup-plugin-svelte#svelte-exports-condition
https://github.com/sveltejs/svelte-loader#resolveconditionnames