Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Pull Request title for preparing release #7102

Merged
merged 1 commit into from Jul 27, 2023

Conversation

ybiquitous
Copy link
Member

Which issue, if any, is this issue related to?

Ref #7089

Is there anything in the PR that needs further explanation?

This change aims to make a Pull Request title for preparing release clearer.
For example, changing from Prepare release to Prepare 15.10.3.

For example, we can locally confirm the script:

$ npx changeset status --output .changeset/status.json

$ new_version=$(jq -r '.releases[0].newVersion' < .changeset/status.json)

$ echo "new-version=${new_version}"
new-version=15.10.3

This change aims to make a Pull Request title for preparing release clearer.
For example, changing from `Prepare release` to `Prepare 15.10.3`.

For example, we can locally confirm the script:

```console
$ npx changeset status --output .changeset/status.json

$ new_version=$(jq -r '.releases[0].newVersion' < .changeset/status.json)

$ echo "new-version=${new_version}"
new-version=15.10.3
```
@changeset-bot
Copy link

changeset-bot bot commented Jul 27, 2023

⚠️ No Changeset found

Latest commit: e2c19b5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you!

@ybiquitous ybiquitous merged commit b9f4255 into main Jul 27, 2023
18 checks passed
@ybiquitous ybiquitous deleted the improve-prepare-pr-title branch July 27, 2023 06:24
@ybiquitous
Copy link
Member Author

It works expectedly 🎉

image

https://github.com/stylelint/stylelint/actions/runs/5677265667/job/15385292550#step:7:3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants