Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Pull Request title example in maintainer guide #7110

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Improve Pull Request title example in maintainer guide #7110

merged 1 commit into from
Jul 27, 2023

Conversation

ybiquitous
Copy link
Member

Which issue, if any, is this issue related to?

Follow-up to #7102

Is there anything in the PR that needs further explanation?

"Prepare release" is now incorrect. The PR title includes a version number.

@ybiquitous
Improve Pull Request title example in maintainer guide
0fed580 
"Prepare release" is now incorrect. The PR title includes a version number.
@changeset-bot
Copy link

changeset-bot bot commented Jul 27, 2023

⚠️ No Changeset found

Latest commit: 0fed580

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

jeddy3
jeddy3 approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

docs/maintainer-guide/releases.md Show resolved Hide resolved
@ybiquitous ybiquitous merged commit a14ffb2 into main Jul 27, 2023
18 checks passed
@ybiquitous ybiquitous deleted the update-pr-title-for-preparing-release-in-maintainer-guide branch July 27, 2023 16:57
@RunDevelopment RunDevelopment mentioned this pull request Aug 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeddy3 jeddy3 jeddy3 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ybiquitous @jeddy3