Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo for --ignore-scripts in package.json #6967

Merged
merged 1 commit into from Jun 24, 2023

Conversation

ybiquitous
Copy link
Member

Which issue, if any, is this issue related to?

Ref: #6964 (comment)

Is there anything in the PR that needs further explanation?

See https://docs.npmjs.com/cli/v9/commands/npm-test#ignore-scripts

@changeset-bot
Copy link

changeset-bot bot commented Jun 24, 2023

⚠️ No Changeset found

Latest commit: cb79337

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -46,10 +46,10 @@
"release": "np --no-release-draft",
"pretest": "npm run lint",
"test": "node --experimental-vm-modules node_modules/jest/bin/jest.js",
"test-coverage": "npm run test --ignore-script -- --coverage",
"test-coverage": "npm test --ignore-scripts -- --coverage",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[note] npm test equals npm run test.

Copy link
Member

@mattxwang mattxwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Surprised we didn't see this earlier. LGTM!

@ybiquitous ybiquitous merged commit 42d4562 into main Jun 24, 2023
18 checks passed
@ybiquitous ybiquitous deleted the fix-typo-of-ignore-script branch June 24, 2023 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants