New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix selector-pseudo-class-no-unknown
false negatives for pseudo-elements with matching names
#6964
Conversation
🦋 Changeset detectedLatest commit: 3cff7f1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
selector-pseudo-class-no-unknown
false negatives for non-standard :slotted
and :placeholder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mouvedia Thanks for the pull request! Can you check my reviews?
selector-pseudo-class-no-unknown
false negatives for non-standard :slotted
and :placeholder
selector-pseudo-class-no-unknown
false negatives for pseudo-elements with matching names
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. LGTM 👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you.
Closes #6878
I have added a test for
:placeholder
because:-moz-placeholder
and:-ms-input-placeholder
exist.i.e. it's a good example of something that the rule will pick up from now on