Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix declaration-block-no-redundant-longhand-properties autofix for grid-column and grid-row #6957

Merged
merged 2 commits into from Jun 23, 2023

Conversation

mattxwang
Copy link
Member

Which issue, if any, is this issue related to?

Closes #6918.

Is there anything in the PR that needs further explanation?

Also fixed the one for grid-row, since it's the same syntax.

@changeset-bot
Copy link

changeset-bot bot commented Jun 22, 2023

🦋 Changeset detected

Latest commit: 27d9ec0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mattxwang mattxwang force-pushed the fix-dbnrlp-grid-row-and-column branch from e16f562 to 162ca8b Compare June 22, 2023 18:25
@Mouvedia
Copy link
Contributor

Ideally, once this and #6956 are merged, we should release right after IMHO.

@mattxwang mattxwang mentioned this pull request Jun 23, 2023
4 tasks
@mattxwang
Copy link
Member Author

we should release right after IMHO.

Sounds good; I'll be able to cut a release this weekend (or earlier/later). Have opened #6959 to discuss.

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. LGTM! 👍🏼

@mattxwang mattxwang merged commit 77824f6 into main Jun 23, 2023
18 checks passed
@mattxwang mattxwang deleted the fix-dbnrlp-grid-row-and-column branch June 23, 2023 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Autofix for grid-column shorthand uses wrong syntax
3 participants