Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 15.9.0 #6959

Closed
4 tasks done
mattxwang opened this issue Jun 23, 2023 · 7 comments
Closed
4 tasks done

Release 15.9.0 #6959

mattxwang opened this issue Jun 23, 2023 · 7 comments
Labels
status: wip is being worked on by someone

Comments

@mattxwang
Copy link
Member

mattxwang commented Jun 23, 2023

  • stylelint release
  • N/A stylelint-config-recommended update
  • N/A stylelint-config-standard update
  • stylelint.io update
  • stylelint-demo check
  • tweet

The current changelog is at https://github.com/stylelint/stylelint/pull/6938/files, though as @Mouvedia has mentioned, the more important items might be three autofixes bugs for declaration-block-no-redundant-properties: #6956, #6957, #6958. I'll also do another pass through the keywords and see if anything else looks off.

Happy to do all the release elements I have perms to (i.e. I'd need help with merging in the new stylelint.io + the tweet, but can do the rest).

@ybiquitous
Copy link
Member

@mattxwang Thanks for opening the issue! Agree 👍🏼

@mattxwang mattxwang added status: wip is being worked on by someone and removed status: needs discussion triage needs further discussion labels Jun 23, 2023
@mattxwang
Copy link
Member Author

mattxwang commented Jun 23, 2023

Hm, so I'm back at a previous problem I had -- I can run np properly (and a new version has been published), but np can't push the commit to main:

$ npm run release
...
  ✔ Pushing tags

✖ Branch protection: np can`t push the commits. Push them manually.

 stylelint 15.9.0 published 🎉

Running either git push or git push --force gives me:

$ git push
Total 0 (delta 0), reused 0 (delta 0), pack-reused 0
remote: error: GH006: Protected branch update failed for refs/heads/main.
remote: error: Changes must be made through a pull request. 13 of 13 required status checks are expected.
To github.com:stylelint/stylelint.git
 ! [remote rejected]     main -> main (protected branch hook declined)
error: failed to push some refs to 'github.com:stylelint/stylelint.git'

Has something changed with my permissions from the last time I've cut a release (15.6.3, ~ 3 weeks ago)? @ybiquitous changed some team membership rules, so perhaps it's that?


Interestingly, the release has been drafted with the right tag.

@ybiquitous
Copy link
Member

@mattxwang Oh, sorry! I removed you from repository access a few days ago because I invited you to the Owners team.

Now, I've regranted you. Can you retry it, please?

I'm unsure why the Owners team members don't have admin access. 🤔

@mattxwang
Copy link
Member Author

No worries at all, and thanks for the speedy response! Looks like that worked (see e56fc6c). Thanks!

@ybiquitous
Copy link
Member

ybiquitous commented Jun 23, 2023

Sorry, I forgot to grant the Owner role @mattxwang and @romainmenke despite inviting them to @stylelint/owners. 🙇🏼

Now, they should have the Owner role. Please let me know if any problems.


EDIT: I've removed Admin access to this repo of @mattxwang again since he has the Owner role already.

@ybiquitous
Copy link
Member

I'll tweet the new release soon.

@ybiquitous
Copy link
Member

All tasks are done! 🎉

@mattxwang Thanks for the releasing work!

And thanks a lot for your great effort and contribution, everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: wip is being worked on by someone
Development

No branches or pull requests

2 participants