Fix selector-pseudo-class-no-unknown false negatives for pseudo-elements with matching names
#6964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3cff7f1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Mouvedia
commented
Jun 23, 2023
ybiquitous
changed the title
selector-pseudo-class-no-unknown false negatives for non-standard :slotted and :placeholder
ybiquitous
requested changes
Jun 23, 2023
There was a problem hiding this comment.
@Mouvedia Thanks for the pull request! Can you check my reviews?
ybiquitous
changed the title
selector-pseudo-class-no-unknown false negatives for non-standard :slotted and :placeholderselector-pseudo-class-no-unknown false negatives for pseudo-elements with matching names
Mouvedia
commented
Jun 24, 2023
This was referenced Jun 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6878
I have added a test for
:placeholderbecause:-moz-placeholderand:-ms-input-placeholderexist.i.e. it's a good example of something that the rule will pick up from now on