Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix declaration-block-no-redundant-longhand-properties autofix for border-width shorthand #6956

Merged
merged 1 commit into from Jun 23, 2023

Conversation

mattxwang
Copy link
Member

Which issue, if any, is this issue related to?

Closes #6947.

Is there anything in the PR that needs further explanation?

Sorry that I missed this! Happy to quickly cut a new release if we'd like.

@changeset-bot
Copy link

changeset-bot bot commented Jun 22, 2023

🦋 Changeset detected

Latest commit: b900c7b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

fixed: 'a { border-width: 0px 1px 2px 3px; }',
description: 'explicit border-width test',
message: messages.expected('border-width'),
},
],
Copy link
Contributor

@Mouvedia Mouvedia Jun 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an example for margin or border-width or padding for top | left/right | bottom.
If if it's not supported yet add skip: true,.
i.e. no need to do it in the same PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, a bit confused -- what do you mean by top | left/right | bottom? Do you mean when all four are specified, or when some of the values are inferred/collapsed? The latter isn't covered by this rule.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latter isn't covered by this rule.

That's why I was proposing to add skip: true for now.
It could be an enhancement; it's expected by users.
cf #6947

@Mouvedia
Copy link
Contributor

Mouvedia commented Jun 22, 2023

Can you add a test for border-radius?
It should be top-left | top-right | bottom-right | bottom-left.

'border-top-right-radius',
'border-top-left-radius',
'border-bottom-right-radius',
'border-bottom-left-radius',

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM! 👍🏼

@mattxwang mattxwang merged commit db315b1 into main Jun 23, 2023
18 checks passed
@mattxwang mattxwang deleted the fix-dbnrlp-border-width-autofix branch June 23, 2023 01:01
mattxwang added a commit that referenced this pull request Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Fix declaration-block-no-redundant-longhand-properties autofix for border-width shorthand
3 participants