Exclude sorbet directory and tapioca script when packing gem #1362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helenye-stripe
requested review from
a team and
pakrym-stripe
and removed request for
a team
helenye-stripe
changed the title
pakrym-stripe
approved these changes
Mar 15, 2024
paracycle
reviewed
Mar 19, 2024
| @@ -33,10 +33,13 @@ Gem::Specification.new do |s| | |||
| /\A\.rubocop/, | |||
| /\A\.travis.yml/, | |||
| /\A\.vscode/, | |||
| %r{\A(bin/tapioca)}, | |||
| /\Asorbet/, | |||
| /\Atest/ | |||
| ) | |||
| s.files = `git ls-files`.split("\n").reject { |f| ignored.match(f) } | |||
| s.executables = `git ls-files -- bin/*`.split("\n") | |||
There was a problem hiding this comment.
I think the real change here should be to move executables exposed by this gem to the exe folder as per the guidance from Bundler since 2015: https://bundler.io/blog/2015/03/20/moving-bins-to-exe.html
Since the convention is to have binstubs and project-local scripts/executables to live in the bin folder, placing executables inside the exe folder is a much better approach than filtering specific files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from comment that pointed out an issue after introducing sorbet in CI.