Move executables to exe folder
#1366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
paracycle
force-pushed
the
uk-update-executable-path
branch
from
e9534d3
to
d7803bb
Compare
|
@paracycle Could you sign the CLA? |
Conventionally `bin` folder is home to scripts that are meant to be run by developers working on the project, whereas the `exe` folder is used for executables that are meant to be exported by the gem. The guidance from the Bundler team around this has been live since 2015: https://bundler.io/blog/2015/03/20/moving-bins-to-exe.html This PR simplifies the gemspec and updates the `bin` folder to `exe` in the gemspec and removes some of the unnecessarily cleanup that was introduced previously.
paracycle
force-pushed
the
uk-update-executable-path
branch
from
d7803bb
to
03fbdf6
Compare
@helenye-stripe apologies for the delay, I have now signed the CLA. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to: https://github.com/stripe/stripe-ruby/pull/1362/files#r1530407652
Conventionally
binfolder is home to scripts that are meant to be run by developers working on the project, whereas theexefolder is used for executables that are meant to be exported by the gem.The guidance from the Bundler team around this has been live since 2015: https://bundler.io/blog/2015/03/20/moving-bins-to-exe.html
This PR simplifies the gemspec and updates the
binfolder toexein the gemspec and removes some of the unnecessarily cleanup that was introduced previously in #1362