-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude sorbet directory and tapioca script when packing gem #1362
Conversation
@@ -33,10 +33,13 @@ Gem::Specification.new do |s| | |||
/\A\.rubocop/, | |||
/\A\.travis.yml/, | |||
/\A\.vscode/, | |||
%r{\A(bin/tapioca)}, | |||
/\Asorbet/, | |||
/\Atest/ | |||
) | |||
s.files = `git ls-files`.split("\n").reject { |f| ignored.match(f) } | |||
s.executables = `git ls-files -- bin/*`.split("\n") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the real change here should be to move executables exposed by this gem to the exe
folder as per the guidance from Bundler since 2015: https://bundler.io/blog/2015/03/20/moving-bins-to-exe.html
Since the convention is to have binstubs and project-local scripts/executables to live in the bin
folder, placing executables inside the exe
folder is a much better approach than filtering specific files.
Follow-up from comment that pointed out an issue after introducing sorbet in CI.