Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#15866): % of users in a11y simulation tool #18003

Merged
merged 6 commits into from May 16, 2022

Conversation

jsomsanith
Copy link
Contributor

@jsomsanith jsomsanith commented Apr 19, 2022

Issue: #15866

What I did

Add percentage of users in a11y simulation options.
The percentages are hard coded as they don't change often, and putting an api in place will be costly compared to the rare updates we can do here.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@nx-cloud
Copy link

nx-cloud bot commented Apr 19, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2dcc9da. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

addons/a11y/src/components/VisionSimulator.tsx Outdated Show resolved Hide resolved
@ndelangen
Copy link
Member

Thank you for the contribution @jsomsanith !!

Copy link
Contributor

@MichaelArestad MichaelArestad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you!

Co-authored-by: Norbert de Langen <ndelangen@me.com>
Copy link
Contributor

@MichaelArestad MichaelArestad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thought, it looks like there is a regression with the preview color swatches. Can you take a look to see why these swatches are no longer showing with the correct filters?

Before

image

After

image

@jsomsanith
Copy link
Contributor Author

Nice catch @MichaelArestad
Fixed :)

Copy link
Contributor

@MichaelArestad MichaelArestad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working perfectly, now! Thank you!

@yannbf
Copy link
Member

yannbf commented May 16, 2022

Hey @jsomsanith thank you so much! This is an awesome contribution 🚀

@yannbf yannbf merged commit a4c1608 into next May 16, 2022
@yannbf yannbf deleted the jsomsanith/feat/15866_a11y_simulator_percentage branch May 16, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants