New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#15866): % of users in a11y simulation tool #18003
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 2dcc9da. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Thank you for the contribution @jsomsanith !! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Thank you!
Co-authored-by: Norbert de Langen <ndelangen@me.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch @MichaelArestad |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's working perfectly, now! Thank you!
Hey @jsomsanith thank you so much! This is an awesome contribution 🚀 |
Issue: #15866
What I did
Add percentage of users in a11y simulation options.
The percentages are hard coded as they don't change often, and putting an api in place will be costly compared to the rare updates we can do here.
How to test
If your answer is yes to any of these, please make sure to include it in your PR.