Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: a11y - show population pourcentage in Accessibility Addon #15866

Closed
Aarbel opened this issue Aug 17, 2021 · 14 comments
Closed

Comments

@Aarbel
Copy link
Contributor

Aarbel commented Aug 17, 2021

Color-blinded Population pourcentage should be shown in Accessibility plugin.

Why ? To see if we test accessibility with a big pourcentage of color-blinded population, or people with low vision.

For example:

  • maybe people with blurred vision on a device are much more than what we expect (idk, maybe 2% of web users), so maybe focusing more on making texts / buttons bigger should bring a better accessibility.
  • maybe Tritanomaly just concerns 0,0001 % of we user, so maybe not a big thing to constraint too much the UI with this accessibility criteria (but surely make it readable for them)

image

@Aarbel
Copy link
Contributor Author

Aarbel commented Aug 17, 2021

Links

- Normal Vision - 92%
- Deuteranomaly - 2,7%
- Protanomaly - 0,66%
- Protanopia - 0,59%
- Deuteranopia - 0,56%
- Tritanopia - 0,016%
- Tritanomaly - 0,01%
- Achromatopsia - 0,0001%
- Achromatomaly - 0,00001%

@Aarbel
Copy link
Contributor Author

Aarbel commented Aug 17, 2021

Can't find metrics about blurred or low vision vision, if someone can help me

cf https://webaim.org/articles/visual/lowvision

uncorrected refractive errors
cataract
age-related macular degeneration
glaucoma
diabetic retinopathy
corneal opacity
trachoma

@Aarbel Aarbel changed the title Feature request: show population purcentage in Accessibility Addon Feature request: show population pourcentage in Accessibility Addon Aug 17, 2021
@Aarbel
Copy link
Contributor Author

Aarbel commented Aug 17, 2021

Code to edit: https://github.com/storybookjs/storybook/blob/07c8974649e0fa95ce1fe8e1b8a0e553754bbdb0/addons/a11y/src/components/VisionSimulator.tsx

To obtain something like this (maybe sorting them by pourcentage would be great)
image

@Aarbel
Copy link
Contributor Author

Aarbel commented Aug 17, 2021

@maya maybe you can help ?

@shilman
Copy link
Member

shilman commented Aug 20, 2021

cc @MichaelArestad

@Aarbel Aarbel changed the title Feature request: show population pourcentage in Accessibility Addon Feature request: a11y - show population pourcentage in Accessibility Addon Aug 20, 2021
@Aarbel
Copy link
Contributor Author

Aarbel commented Aug 25, 2021

@MichaelArestad @maya any help / news about it ?

@MichaelArestad
Copy link
Contributor

@Aarbel Thanks for proposing this! In the screenshot above, where the percentages are next to the modes, it is not immediately clear to me what the percentages represent. I don't have any ideas for ways to include this information yet, but I will be thinking about it as I work on the accessibility addon.

It would be good if we could get this data via an API so it will remain updated.

@Aarbel
Copy link
Contributor Author

Aarbel commented Aug 26, 2021

@MichaelArestad i agree that in term of ui a text like "Deuteranomaly (2,7% of users)" would be better, but quite redundant with all dropdown items. That's just a UI detail anyway, before that "Deuteranomaly" has first nos sense for most users.

About API: i don't know an api that gives this "vision" metrics updated. We will surely have to update it every 5 years from Wikipedia, with certainly little variations. Not so a big maintance thing.

The only data i'm missing is the population percentage of low vision, cf #15866 (comment)

@jsomsanith
Copy link
Contributor

Hey everyone,
What about this mockup ?
image

Agree that this is not some critical info that changes everytime, and an update maintenance each year doesn't cost anything instead of getting it from api

@MichaelArestad
Copy link
Contributor

@jsomsanith I dig this mockup! I might change it to 2,7% of users (no "the")

@jsomsanith
Copy link
Contributor

jsomsanith commented Apr 18, 2022

👍 I can remove the the
If the visual is ok, I can work on a PR

@Aarbel
Copy link
Contributor Author

Aarbel commented Apr 19, 2022

@jsomsanith for blurred vision (mainly myopa):

22.9%

https://www.aaojournal.org/article/s0161-6420(16)00025-7/pdf#:~:text=We%20estimated%201406%20million%20people,e%206.3%25%5D)%20in%202000.

@Aarbel
Copy link
Contributor Author

Aarbel commented May 17, 2022

🙌

@shilman
Copy link
Member

shilman commented May 17, 2022

Ta-da!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.5.0-rc.0 containing PR #18003 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb upgrade --prerelease

kevcube pushed a commit to kevcube/storybook that referenced this issue Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants