fix windows ci #2400
Merged
fix windows ci #2400
+10
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
👋 Hi,
This is a reminder message to assign an extra build label to this Pull Request if needed.
By default, this PR will be build with minimal build options (URDF support and Python bindings)
The possible extra labels are:
- build_collision (build Pinocchio with coal support)
- build_casadi (build Pinocchio with CasADi support)
- build_autodiff (build Pinocchio with CppAD support)
- build_codegen (build Pinocchio with CppADCodeGen support)
- build_extra (build Pinocchio with extra algorithms)
- build_mpfr (build Pinocchio with Boost.Multiprecision support)
- build_sdf (build Pinocchio with SDF parser)
- build_accelerate (build Pinocchio with APPLE Accelerate framework support)
- build_all (build Pinocchio with ALL the options stated above)
Thanks.
The Pinocchio development team.
|
clang-cl doesn't seem to like some boost::archive stuff |
Indeed, this is related to a current issue on conda-forge that @fabinsch is now fixing :) |
|
Similar to our conda-feedstock, we now get a linker error on Windows with clang-cl. Not setting the CMP0167 policy, e.g. removing this commit, results in a lot of warning but allows to compile and link on windows with clang-cl. |
|
@fabinsch could you push your fix here? |
jcarpent
requested changes
Aug 30, 2024
jcarpent
previously approved these changes
Aug 30, 2024
jcarpent
approved these changes
Aug 30, 2024
nim65s
added a commit
to nim65s/robotpkg
that referenced
this pull request
Nov 8, 2024
## [3.3.0] - 2024-11-06
### Added
- Default visualizer can be changed with `PINOCCHIO_VIEWER` environment variable stack-of-tasks/pinocchio#2419
- Add more Python and C++ examples related to inverse kinematics with 3d tasks stack-of-tasks/pinocchio#2428
- Add parsing of equality/connect tag for closed-loop chains for MJCF format stack-of-tasks/pinocchio#2413
- Add compatibility with NumPy 2 `__array__` API stack-of-tasks/pinocchio#2436
- Added argument to let users decide of root joint name when parsing models (urdf, mjcf, sdf) stack-of-tasks/pinocchio#2402
- Allow use of `pathlib.Path | str` for paths in python bindings stack-of-tasks/pinocchio#2431
- Add Pseudo inertia and Log-cholesky parametrization stack-of-tasks/pinocchio#2296
- Add Pixi support stack-of-tasks/pinocchio#2459
### Fixed
- Fix linkage of Boost.Serialization on Windows stack-of-tasks/pinocchio#2400
- Fix mjcf parser appending of inertias at root joint stack-of-tasks/pinocchio#2403
- Fix unit tests with GCC 13.3 stack-of-tasks/pinocchio#2416)
- Fix class abstract error for Rviz viewer stack-of-tasks/pinocchio#2425
- Fix compilation issue with MSCV and C++17 stack-of-tasks/pinocchio#2437
- Fix `pinocchio-test-py-robot_wrapper` when building with SDF and collision support stack-of-tasks/pinocchio#2437
- Fix crash when calling `Inertia::FromDynamicParameters` in Python with wrong vector size stack-of-tasks/pinocchio#2296
- Fix `examples/cassie-simulation.py` and `examples/talos-simulation.py` stack-of-tasks/pinocchio#2443
- Fix build with CppAd 2024 stack-of-tasks/pinocchio#2459
- Fix `pinocchio-test-cpp-mjcf` unittest with Boost 1.86 stack-of-tasks/pinocchio#2459
- Fix `pinocchio-test-cpp-constraint-variants` uninitialized values stack-of-tasks/pinocchio#2459
- Fix mixing library symbols between Pinocchio scalar bindings stack-of-tasks/pinocchio#2459
- Fix bug for get{Joint,Frame}JacobianTimeVariation stack-of-tasks/pinocchio#2466
### Changed
- Modernize python code base with ruff stack-of-tasks/pinocchio#2418
- Does not create a root_joint frame from parsed models (urdf, mjcf and sdf) when no root joint is provided stack-of-tasks/pinocchio#2402
nim65s
added a commit
to nim65s/robotpkg
that referenced
this pull request
Nov 21, 2024
## [3.3.0] - 2024-11-06
### Added
- Default visualizer can be changed with `PINOCCHIO_VIEWER` environment variable stack-of-tasks/pinocchio#2419
- Add more Python and C++ examples related to inverse kinematics with 3d tasks stack-of-tasks/pinocchio#2428
- Add parsing of equality/connect tag for closed-loop chains for MJCF format stack-of-tasks/pinocchio#2413
- Add compatibility with NumPy 2 `__array__` API stack-of-tasks/pinocchio#2436
- Added argument to let users decide of root joint name when parsing models (urdf, mjcf, sdf) stack-of-tasks/pinocchio#2402
- Allow use of `pathlib.Path | str` for paths in python bindings stack-of-tasks/pinocchio#2431
- Add Pseudo inertia and Log-cholesky parametrization stack-of-tasks/pinocchio#2296
- Add Pixi support stack-of-tasks/pinocchio#2459
### Fixed
- Fix linkage of Boost.Serialization on Windows stack-of-tasks/pinocchio#2400
- Fix mjcf parser appending of inertias at root joint stack-of-tasks/pinocchio#2403
- Fix unit tests with GCC 13.3 stack-of-tasks/pinocchio#2416)
- Fix class abstract error for Rviz viewer stack-of-tasks/pinocchio#2425
- Fix compilation issue with MSCV and C++17 stack-of-tasks/pinocchio#2437
- Fix `pinocchio-test-py-robot_wrapper` when building with SDF and collision support stack-of-tasks/pinocchio#2437
- Fix crash when calling `Inertia::FromDynamicParameters` in Python with wrong vector size stack-of-tasks/pinocchio#2296
- Fix `examples/cassie-simulation.py` and `examples/talos-simulation.py` stack-of-tasks/pinocchio#2443
- Fix build with CppAd 2024 stack-of-tasks/pinocchio#2459
- Fix `pinocchio-test-cpp-mjcf` unittest with Boost 1.86 stack-of-tasks/pinocchio#2459
- Fix `pinocchio-test-cpp-constraint-variants` uninitialized values stack-of-tasks/pinocchio#2459
- Fix mixing library symbols between Pinocchio scalar bindings stack-of-tasks/pinocchio#2459
- Fix bug for get{Joint,Frame}JacobianTimeVariation stack-of-tasks/pinocchio#2466
### Changed
- Modernize python code base with ruff stack-of-tasks/pinocchio#2418
- Does not create a root_joint frame from parsed models (urdf, mjcf and sdf) when no root joint is provided stack-of-tasks/pinocchio#2402
nim65s
added a commit
to nim65s/robotpkg
that referenced
this pull request
Dec 6, 2024
## [3.3.0] - 2024-11-06
### Added
- Default visualizer can be changed with `PINOCCHIO_VIEWER` environment variable stack-of-tasks/pinocchio#2419
- Add more Python and C++ examples related to inverse kinematics with 3d tasks stack-of-tasks/pinocchio#2428
- Add parsing of equality/connect tag for closed-loop chains for MJCF format stack-of-tasks/pinocchio#2413
- Add compatibility with NumPy 2 `__array__` API stack-of-tasks/pinocchio#2436
- Added argument to let users decide of root joint name when parsing models (urdf, mjcf, sdf) stack-of-tasks/pinocchio#2402
- Allow use of `pathlib.Path | str` for paths in python bindings stack-of-tasks/pinocchio#2431
- Add Pseudo inertia and Log-cholesky parametrization stack-of-tasks/pinocchio#2296
- Add Pixi support stack-of-tasks/pinocchio#2459
### Fixed
- Fix linkage of Boost.Serialization on Windows stack-of-tasks/pinocchio#2400
- Fix mjcf parser appending of inertias at root joint stack-of-tasks/pinocchio#2403
- Fix unit tests with GCC 13.3 stack-of-tasks/pinocchio#2416)
- Fix class abstract error for Rviz viewer stack-of-tasks/pinocchio#2425
- Fix compilation issue with MSCV and C++17 stack-of-tasks/pinocchio#2437
- Fix `pinocchio-test-py-robot_wrapper` when building with SDF and collision support stack-of-tasks/pinocchio#2437
- Fix crash when calling `Inertia::FromDynamicParameters` in Python with wrong vector size stack-of-tasks/pinocchio#2296
- Fix `examples/cassie-simulation.py` and `examples/talos-simulation.py` stack-of-tasks/pinocchio#2443
- Fix build with CppAd 2024 stack-of-tasks/pinocchio#2459
- Fix `pinocchio-test-cpp-mjcf` unittest with Boost 1.86 stack-of-tasks/pinocchio#2459
- Fix `pinocchio-test-cpp-constraint-variants` uninitialized values stack-of-tasks/pinocchio#2459
- Fix mixing library symbols between Pinocchio scalar bindings stack-of-tasks/pinocchio#2459
- Fix bug for get{Joint,Frame}JacobianTimeVariation stack-of-tasks/pinocchio#2466
### Changed
- Modernize python code base with ruff stack-of-tasks/pinocchio#2418
- Does not create a root_joint frame from parsed models (urdf, mjcf and sdf) when no root joint is provided stack-of-tasks/pinocchio#2402
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, ensure proper handling of both cl.exe and clang-cl.exe. Previously, our setup did not use clang-cl.exe.