Consider initializer annotations when looking for UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR
#2872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuditKnoll
approved these changes
Feb 22, 2024
spotbugs/src/main/java/edu/umd/cs/findbugs/detect/UnreadFields.java
Outdated
Show resolved
Hide resolved
|
Thanks for reviewing @JuditKnoll, I have made the changes |
JuditKnoll
approved these changes
Feb 22, 2024
This was
linked to
issues
Feb 22, 2024
Closed
ThrawnCA
reviewed
Feb 22, 2024
| for (AnnotationEntry a : getMethod().getAnnotationEntries()) { | ||
| String typeName = a.getAnnotationType(); | ||
|
|
||
| if ("Ljakarta/annotation/PostConstruct;".equals(typeName) |
There was a problem hiding this comment.
Could put these in an ordered array and use Arrays.binarySearch, or an ArrayList and use contains.
There was a problem hiding this comment.
I have moved the annotations in a list. Considering the small size I used contains() for simplicity
ThrawnCA
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #453 and #2870