Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat unit test setup methods as constructors for UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR #453

Closed
ThrawnCA opened this issue Oct 16, 2017 · 3 comments · Fixed by #2872
Closed

Treat unit test setup methods as constructors for UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR #453

ThrawnCA opened this issue Oct 16, 2017 · 3 comments · Fixed by #2872
Labels
enhancement

Comments

@ThrawnCA
Copy link
Contributor

JUnit and TestNG test classes typically initialise their fields within a setup method, rather than the constructor, which often results in UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR. Can appropriately-annotated setup methods (@Before, @BeforeMethod, @BeforeClass) be treated as constructors for this purpose?
@rscarvalho
Copy link

any updates on this?

@jansohn
Copy link

jansohn commented Dec 14, 2023

We also start seeing this with JUnit 5 and its annotation @BeforeEach

@hazendaz
Copy link
Member

Would need @BeforeAll as well.

@famod famod mentioned this issue Feb 21, 2024
Closed
gtoison added a commit to gtoison/spotbugs that referenced this issue Feb 22, 2024
@gtoison
test: reproducer for issue spotbugs#453
e89d3b9
@gtoison gtoison mentioned this issue Feb 22, 2024
Merged
@gtoison gtoison linked a pull request Feb 22, 2024 that will close this issue
Consider initializer annotations when looking for UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR #2872
Merged
hazendaz pushed a commit that referenced this issue Feb 24, 2024
@gtoison
Consider initializer annotations when looking for `UWF_FIELD_NOT_INIT…
5ec24da 
…IALIZED_IN_CONSTRUCTOR` (#2872)

* test: reproducer for issue #453

* fix: consider annotations when looking for initializer methods

* fix: typo, added reference to issues

* fix: moved the annotations list into a constant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
5 participants
@rscarvalho @iloveeclipse @hazendaz @ThrawnCA @jansohn