[Merged by Bors] - prune active set from ballot blob #5032
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
countvonzero
requested review from
dshulyak,
fasmat and
poszu
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #5032 +/- ##
=========================================
- Coverage 77.1% 77.0% -0.1%
=========================================
Files 257 257
Lines 30277 30277
=========================================
- Hits 23349 23343 -6
- Misses 5402 5408 +6
Partials 1526 1526
|
countvonzero
force-pushed
the
finally-prune-activeset
branch
from
b9ecc3b
to
bca55ef
Compare
dshulyak
approved these changes
Sep 25, 2023
countvonzero
force-pushed
the
finally-prune-activeset
branch
from
bca55ef
to
91f5b2c
Compare
countvonzero
changed the title
|
bors merge |
dshulyak
reviewed
Sep 25, 2023
| @@ -34,6 +34,7 @@ In order to enable provide following configuration: | |||
| Ephemeral data are deleted and state compacted at the time of upgrade. In steady-state, data is pruned periodically. | |||
| * [#5021](https://github.com/spacemeshos/go-spacemesh/pull/5021) Drop support for old certificate sync protocol. | |||
| * [#5024](https://github.com/spacemeshos/go-spacemesh/pull/5024) Active set will be saved in state separately from ballots. | |||
| * [#5032](https://github.com/spacemeshos/go-spacemesh/pull/5032) Ativeset data pruned from ballots. | |||
There was a problem hiding this comment.
we should put a bit more data about this. e.g expected time and amount of storage required to perform this migration (e.g. WAL is the size of database right?) . we can do that after benchmarking in cloud
There was a problem hiding this comment.
yes. WAL will be the size of the pre-vacuumed db (it's being used as a tmp storage during vacuum).
will update after testing.
bors bot
pushed a commit
that referenced
this pull request
Sep 25, 2023
## Motivation Closes #4985 ## Changes - actually prune active set from ballot blobs in db - use a empty migration to facilitate the pruning. we only want to prune/vacuum/checkpoint once per software upgrade the code allow any upgrade from migration <=4 to 5 to - extract active set from ballots - prune active set from blob - vacuum and checkpoint the final size of the state should be < 1GB
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Sep 25, 2023
## Motivation Closes #4985 ## Changes - actually prune active set from ballot blobs in db - use a empty migration to facilitate the pruning. we only want to prune/vacuum/checkpoint once per software upgrade the code allow any upgrade from migration <=4 to 5 to - extract active set from ballots - prune active set from blob - vacuum and checkpoint the final size of the state should be < 1GB
|
bors cancel |
|
Canceled. |
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Sep 25, 2023
## Motivation Closes #4985 ## Changes - actually prune active set from ballot blobs in db - use a empty migration to facilitate the pruning. we only want to prune/vacuum/checkpoint once per software upgrade the code allow any upgrade from migration <=4 to 5 to - extract active set from ballots - prune active set from blob - vacuum and checkpoint the final size of the state should be < 1GB
|
Pull request successfully merged into develop. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #4985
Changes
we only want to prune/vacuum/checkpoint once per software upgrade
the code allow any upgrade from migration <=4 to 5 to
the final size of the state should be < 1GB