pruen active set from ballot blob

sql/ballots/util/extract.go

@@ -4,6 +4,7 @@ import (
 	"errors"
 	"fmt"
 
+	"github.com/spacemeshos/go-spacemesh/codec"
 	"github.com/spacemeshos/go-spacemesh/common/types"
 	"github.com/spacemeshos/go-spacemesh/log"
 	"github.com/spacemeshos/go-spacemesh/sql"
@@ -42,11 +43,10 @@ func ExtractActiveSet(db sql.Executor) error {
 			} else if err == nil {
 				unique++
 			}
-			// TODO: prune ballot active set after migration 4 is released
-			//b.ActiveSet = nil
-			//if err := ballots.UpdateBlob(db, b.ID(), codec.MustEncode(b)); err != nil {
-			//	return fmt.Errorf("update ballot %s: %w", b.ID().String(), err)
-			//}
+			b.ActiveSet = nil
+			if err := ballots.UpdateBlob(db, b.ID(), codec.MustEncode(b)); err != nil {
+				return fmt.Errorf("update ballot %s: %w", b.ID().String(), err)
+			}
 			extracted++
 		}
 	}

sql/ballots/util/extract_test.go

@@ -45,9 +45,7 @@ func TestExtractActiveSet(t *testing.T) {
 	for _, b := range blts {
 		got, err := ballots.Get(db, b.ID())
 		require.NoError(t, err)
-		if b.Layer%3 != 2 {
-			require.NotEmpty(t, got.ActiveSet)
-		}
+		require.Nil(t, got.ActiveSet)
 	}
 	for i, h := range hashes {
 		got, err := activesets.Get(db, h)

sql/database.go

@@ -145,7 +145,7 @@ func Open(uri string, opts ...Opt) (*Database, error) {
 		if err != nil {
 			return nil, err
 		}
-		if before <= 3 && after == 4 && config.v4Migration != nil {
+		if before <= 4 && after == 5 && config.v4Migration != nil {
 			// v4 migration (active set extraction) needs the 3rd migration to execute first
 			if err := config.v4Migration(db); err != nil {
 				return nil, err

sql/migrations/0005_next.sql

@@ -0,0 +1 @@
+-- empty migration file to facilitate pruning active set from ballot blobs

sql/migrations_test.go

@@ -15,5 +15,5 @@ func TestMigrationsAppliedOnce(t *testing.T) {
 		return true
 	})
 	require.NoError(t, err)
-	require.Equal(t, version, 4)
+	require.Equal(t, version, 5)
 }