Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Move staticcheck step to lint job #4762

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Move staticcheck step to lint job #4762

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af1106e
Move staticcheck step to lint job
fasmat Aug 1, 2023
c4b66db
OCL and driver is still required for test-generate
fasmat Aug 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 8 additions & 6 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@ jobs:
runs-on: ubuntu-latest
needs: filter-changes
if: ${{ needs.filter-changes.outputs.nondocchanges == 'true' }}
# should not take more than 7-8 mins
timeout-minutes: 10
# should not take more than 2-3 mins
timeout-minutes: 5
steps:
- name: Add OpenCL support
run: sudo apt-get update -q && sudo apt-get install -qy ocl-icd-opencl-dev libpocl2
Expand All @@ -72,16 +72,16 @@ jobs:
make test-fmt
make test-tidy
make test-generate
- name: staticcheck
run: make staticcheck

lint:
runs-on: ubuntu-latest
needs: filter-changes
if: ${{ needs.filter-changes.outputs.nondocchanges == 'true' }}
# should not take more than 4-6 mins
timeout-minutes: 10
# should not take more than 15-16 mins
timeout-minutes: 18
steps:
- name: Add OpenCL support
run: sudo apt-get update -q && sudo apt-get install -qy ocl-icd-opencl-dev libpocl2
- name: checkout
uses: actions/checkout@v3
- name: set up go
Expand All @@ -91,6 +91,8 @@ jobs:
go-version-file: "go.mod"
- name: setup env
run: make install
- name: staticcheck
run: make staticcheck
- name: lint
run: make lint-github-action

Expand Down