-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Move staticcheck step to lint job #4762
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #4762 +/- ##
=========================================
- Coverage 76.8% 76.8% -0.1%
=========================================
Files 259 259
Lines 29432 29432
=========================================
- Hits 22617 22610 -7
- Misses 5378 5383 +5
- Partials 1437 1439 +2 |
bcf0235
to
c4b66db
Compare
bors merge |
## Motivation Quicktests recently have often timed out when they should pass or fail quickly to catch easy detectable mistakes (primarily formatting and dependency issues at the moment). The staticcheck fits well into the lint job with the other linters invoked by `golangci-lint` (btw. shouldn't staticcheck already be called by golangci-lint? 馃 ) If the lint job takes longer that's not a big deal; it runs in parallel to most other jobs and unittests take much longer anyway so the overall time for CI won't increase by this. ## Changes - Move `staticcheck` from quicktests job to lint job. - Set new timeouts that should be long enough to avoid being triggered in a normal run. ## Test Plan <!-- Please specify how these changes were tested (e.g. unit tests, manual testing, etc.) --> ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Update documentation as needed ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
Pull request successfully merged into develop. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Motivation
Quicktests recently have often timed out when they should pass or fail quickly to catch easy detectable mistakes (primarily formatting and dependency issues at the moment).
The staticcheck fits well into the lint job with the other linters invoked by
golangci-lint
(btw. shouldn't staticcheck already be called by golangci-lint? 馃 ) If the lint job takes longer that's not a big deal; it runs in parallel to most other jobs and unittests take much longer anyway so the overall time for CI won't increase by this.Changes
staticcheck
from quicktests job to lint job.Test Plan
TODO
DevOps Notes