[Merged by Bors] - Move staticcheck step to lint job #4762
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #4762 +/- ##
=========================================
- Coverage 76.8% 76.8% -0.1%
=========================================
Files 259 259
Lines 29432 29432
=========================================
- Hits 22617 22610 -7
- Misses 5378 5383 +5
- Partials 1437 1439 +2 |
fasmat
force-pushed
the
move-staticcheck-to-lint
branch
from
bcf0235
to
c4b66db
Compare
dshulyak
approved these changes
Aug 2, 2023
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Aug 2, 2023
## Motivation Quicktests recently have often timed out when they should pass or fail quickly to catch easy detectable mistakes (primarily formatting and dependency issues at the moment). The staticcheck fits well into the lint job with the other linters invoked by `golangci-lint` (btw. shouldn't staticcheck already be called by golangci-lint? 馃 ) If the lint job takes longer that's not a big deal; it runs in parallel to most other jobs and unittests take much longer anyway so the overall time for CI won't increase by this. ## Changes - Move `staticcheck` from quicktests job to lint job. - Set new timeouts that should be long enough to avoid being triggered in a normal run. ## Test Plan <!-- Please specify how these changes were tested (e.g. unit tests, manual testing, etc.) --> ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Update documentation as needed ## DevOps Notes <!-- Please uncheck these items as applicable to make DevOps aware of changes that may affect releases --> - [x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources) - [x] This PR does not affect public APIs - [x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.) - [x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)
|
Pull request successfully merged into develop. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Quicktests recently have often timed out when they should pass or fail quickly to catch easy detectable mistakes (primarily formatting and dependency issues at the moment).
The staticcheck fits well into the lint job with the other linters invoked by
golangci-lint(btw. shouldn't staticcheck already be called by golangci-lint? 馃 ) If the lint job takes longer that's not a big deal; it runs in parallel to most other jobs and unittests take much longer anyway so the overall time for CI won't increase by this.Changes
staticcheckfrom quicktests job to lint job.Test Plan
TODO
DevOps Notes