Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove now unused exports from Transactions library #2492

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

mcintyre94
Copy link
Collaborator

  • I'm going to remove a bunch of this code, but want to make sure nothing breaks here first!

Copy link

changeset-bot bot commented Apr 16, 2024

⚠️ No Changeset found

Latest commit: 4cf8368

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mcintyre94 mcintyre94 marked this pull request as ready for review April 16, 2024 12:53
Copy link
Collaborator

@lorisleiva lorisleiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

Copy link
Collaborator

@steveluscher steveluscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sleepymelo-explosion

Copy link
Collaborator Author

mcintyre94 commented Apr 18, 2024

Merge activity

  • Apr 18, 2:34 AM EDT: @mcintyre94 started a stack merge that includes this pull request via Graphite.
  • Apr 18, 2:37 AM EDT: Graphite rebased this pull request as part of a merge.
  • Apr 18, 2:39 AM EDT: @mcintyre94 merged this pull request with Graphite.

Base automatically changed from send-tx-new to master April 18, 2024 06:36
- I'm going to remove a bunch of this code, but want to make sure nothing breaks here first!
- Remove the typetests with old code - this is all in either transaction-messages or new typetests
Copy link
Contributor

🎉 This PR is included in version 1.91.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link
Contributor

github-actions bot commented May 3, 2024

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants