Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor resolve-transaction-error-test to use createTransactionMessage #2488

Closed
wants to merge 1 commit into from

Conversation

mcintyre94
Copy link
Collaborator

@mcintyre94 mcintyre94 commented Apr 16, 2024

  • Remove export of blockhash, compilable-transaction, create-transaction from transactions package

I think the major uses of the old transaction model are now removed, but there's a bunch of smaller ones left. I'm going to begin removing exports from the transactions package wherever possible, refactoring whatever requires them still as I go.

The old serializers will be removed last, and with them all of these files too. Until they're removed the files are required in the package, but don't need to be exported.

Copy link

changeset-bot bot commented Apr 16, 2024

⚠️ No Changeset found

Latest commit: d9bb5aa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

- Remove export of blockhash, compilable-transaction, create-transaction from transactions package
Copy link
Collaborator

@lorisleiva lorisleiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to avoid touching the @solana/programs package for now since I've basically removed everything from it and added a new isProgramError helper instead.

When doing so, I've made sure to use @solana/transaction-messages instead of @solana/transactions so that package should be good to go after my couple of PRs.

@mcintyre94
Copy link
Collaborator Author

Awesome thanks, I'll close this in favour of your PRs! :)

Copy link
Contributor

github-actions bot commented May 2, 2024

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants