-
Notifications
You must be signed in to change notification settings - Fork 770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor resolve-transaction-error-test to use createTransactionMessage #2488
Conversation
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @mcintyre94 and the rest of your teammates on Graphite |
- Remove export of blockhash, compilable-transaction, create-transaction from transactions package
30f0d8e
to
d9bb5aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may want to avoid touching the @solana/programs
package for now since I've basically removed everything from it and added a new isProgramError
helper instead.
When doing so, I've made sure to use @solana/transaction-messages
instead of @solana/transactions
so that package should be good to go after my couple of PRs.
Awesome thanks, I'll close this in favour of your PRs! :) |
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
I think the major uses of the old transaction model are now removed, but there's a bunch of smaller ones left. I'm going to begin removing exports from the
transactions
package wherever possible, refactoring whatever requires them still as I go.The old serializers will be removed last, and with them all of these files too. Until they're removed the files are required in the package, but don't need to be exported.