New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor send-transaction to use NewTransaction #2487
Conversation
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @mcintyre94 and the rest of your teammates on Graphite |
172c221
to
fd28deb
Compare
fd28deb
to
fbcde3c
Compare
807b600
to
d77e79d
Compare
This is now just cleaning up some stuff earlier in the stack, mostly in #2485 - I had to pull most of the code changes back to that branch |
d77e79d
to
65ab349
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
65ab349
to
5e84c3c
Compare
Merge activity
|
🎉 This PR is included in version 1.91.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
This PR replaces the helpers for sending transactions to send
NewTransaction
objects, and to use the lifetime helpers.We replace
SendableTransaction
withFullySignedTransaction
, and mix in the lifetime constraints when required.