Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile serde_derive separately from serde #866

Closed
wants to merge 1 commit into from
Closed

Compile serde_derive separately from serde #866

wants to merge 1 commit into from

Commits on Aug 30, 2023

  1. Compile serde_derive separately from serde 

    When serde's derive feature is used, serde_derive must be
compiled before serde can be, as serde with that feature has a
serde_derive dependency.

As of serde 1.0.186, this issue can be avoided by adding a separate
serde_derive dependency due to the fact that serde 1.0.186 has a
never-applicable dependency on serde_derive, which ensures that
there is no incompatible version of serde_derive in a program [1].

Because MSRV being set to 1.56, it's not possible to use the dep:
syntax in features, so serde crate needs to be renamed.

This should improve compilation times of programs that use url
with its serde feature, provided it doesn't have other crates that
use serde with its derive feature.

[1]: serde-rs/serde#2588
    @KamilaBorowska
    KamilaBorowska committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    0d78e8a View commit details
    Browse the repository at this point in the history