Compile serde_derive separately from serde #866
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When serde's derive feature is used, serde_derive must be compiled before serde can be, as serde with that feature has a serde_derive dependency. As of serde 1.0.186, this issue can be avoided by adding a separate serde_derive dependency due to the fact that serde 1.0.186 has a never-applicable dependency on serde_derive, which ensures that there is no incompatible version of serde_derive in a program [1]. Because MSRV being set to 1.56, it's not possible to use the dep: syntax in features, so serde crate needs to be renamed. This should improve compilation times of programs that use url with its serde feature, provided it doesn't have other crates that use serde with its derive feature. [1]: serde-rs/serde#2588
|
Albeit, it seems like according to serde-rs/serde#2584, the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
serde'sderivefeature is used,serde_derivemust be compiled beforeserdecan be, asserdewith that feature has aserde_derivedependency.As of serde 1.0.186, this issue can be avoided by adding a separate
serde_derivedependency due to the fact that serde 1.0.186 has a never-applicable dependency onserde_derive, which ensures that there is no incompatible version ofserde_derivein a program (serde-rs/serde#2588).Because MSRV being set to 1.56, it's not possible to use the
dep:syntax in features, soserdecrate needs to be renamed.dep:syntax was added in Rust 1.60 if we want to bump MSRV.This should improve compilation times of programs that use
urlwith itsserdefeature, provided it doesn't have other crates that useserdewith itsderivefeature.