Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH Adds TargetEncoder #25334
ENH Adds TargetEncoder #25334
Changes from 56 commits
f29c2d8
336b17d
c52ce42
1863be9
22af6a6
f535f54
c6d1fc4
2868b3c
aa6e545
871ea45
71e6bad
fdd39d0
c8d5546
6a5771c
6dbcb85
00d5230
e75a51e
2978e23
429085d
93ea268
cfe7afa
3967934
7875c2e
5ff5b61
2568e89
afc4223
6e4bf50
d613c61
ba85edb
e3c8473
0d6c4a2
d9cd410
ee1e26b
a399791
fd2b963
cd6c650
991fd9f
962125d
02d8346
acb4b2e
3261d10
a57b117
5a330be
f1a14d7
66fb8bd
f5df8b8
906ac98
43630cf
177128d
e37b6ec
86d357e
a7cc80f
0bcad5b
61081db
2e4bd85
07a225c
7cd0c8d
94fd097
56dd2fa
317e13a
c4eacfa
0ab474b
c09556c
b7654bb
387f42c
efe630c
803a988
f5f7ab1
0e784b1
444f589
4994bc4
8fb1a11
850694e
665e2e9
5247123
70f99fe
e09660c
690fcdc
a327b52
6b27afd
9773765
8e18746
1ea0407
df5574d
d681e06
0b458c3
26d2429
d77e519
05997bb
6377419
180ee0e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the use of cross-validation and its motivation should be described in more details, possibly in a new paragraph before the note. Then the note could be shortened to:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would help to have a schematic/diagram to explain how the CV process works during
fit
and how encoder works attransform
time.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I expanded on how
fit_transform
andfit
by itself works, along with a diagram to explain how the CV process works infit_transform
.