Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH Adds TargetEncoder #25334

Merged
merged 91 commits into from
Mar 16, 2023
Merged

ENH Adds TargetEncoder #25334

merged 91 commits into from
Mar 16, 2023

Commits on Jan 8, 2023

  1. ENH Adds Target Regression Encoder

    @thomasjpfan
    thomasjpfan committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    f29c2d8 View commit details
    Browse the repository at this point in the history

  2. DOC Adds pr number

    @thomasjpfan
    thomasjpfan committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    336b17d View commit details
    Browse the repository at this point in the history

  3. DOC Adds pr number

    @thomasjpfan
    thomasjpfan committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    c52ce42 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2023

  1. DOC Adds example

    @thomasjpfan
    thomasjpfan committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    1863be9 View commit details
    Browse the repository at this point in the history

  2. DOC Fixes example link

    @thomasjpfan
    thomasjpfan committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    22af6a6 View commit details
    Browse the repository at this point in the history

  3. FIX Use fancy indexing

    @thomasjpfan
    thomasjpfan committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    f535f54 View commit details
    Browse the repository at this point in the history

  4. FIX Fix issue with 32bit

    @thomasjpfan
    thomasjpfan committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    c6d1fc4 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2023

  1. ENH Adds support for binary classification

    @thomasjpfan
    thomasjpfan committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    2868b3c View commit details
    Browse the repository at this point in the history

  2. TST Adds test to check target_type_

    @thomasjpfan
    thomasjpfan committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    aa6e545 View commit details
    Browse the repository at this point in the history

  3. DOC Update whats new with better wording

    @thomasjpfan
    thomasjpfan committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    871ea45 View commit details
    Browse the repository at this point in the history

  4. DOC Update docs about target encoder itself

    @thomasjpfan
    thomasjpfan committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    71e6bad View commit details
    Browse the repository at this point in the history

  5. TST Update names of tests

    @thomasjpfan
    thomasjpfan committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    fdd39d0 View commit details
    Browse the repository at this point in the history

  6. DOC better names for variables

    @thomasjpfan
    thomasjpfan committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    c8d5546 View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'upstream/main' into target_regression_e… 

    …ncoder_v2_pr
    @thomasjpfan
    thomasjpfan committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    6a5771c View commit details
    Browse the repository at this point in the history

  8. ENH Adds target_type parameter

    @thomasjpfan
    thomasjpfan committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    6dbcb85 View commit details
    Browse the repository at this point in the history

  9. TST Fixes test failures

    @thomasjpfan
    thomasjpfan committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    00d5230 View commit details
    Browse the repository at this point in the history

  10. DOC Remove mention on RMSE

    @thomasjpfan
    thomasjpfan committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    e75a51e View commit details
    Browse the repository at this point in the history

  11. DOC Adds concluding statement in example

    @thomasjpfan
    thomasjpfan committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    2978e23 View commit details
    Browse the repository at this point in the history

  12. CLN Refactor names

    @thomasjpfan
    thomasjpfan committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    429085d View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2023

  1. DOC Improves user guide

    @thomasjpfan
    thomasjpfan committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    93ea268 View commit details
    Browse the repository at this point in the history

  2. CLN Cleaner implementation

    @thomasjpfan
    thomasjpfan committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    cfe7afa View commit details
    Browse the repository at this point in the history

  3. ENH Adds auto for smoothing

    @thomasjpfan
    thomasjpfan committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    3967934 View commit details
    Browse the repository at this point in the history

  4. CLN Address comments

    @thomasjpfan
    thomasjpfan committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    7875c2e View commit details
    Browse the repository at this point in the history

  5. DOC Update example title

    @thomasjpfan
    thomasjpfan committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    5ff5b61 View commit details
    Browse the repository at this point in the history

  6. DOC Adds comment to point to equation

    @thomasjpfan
    thomasjpfan committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    2568e89 View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'upstream/main' into target_regression_e… 

    …ncoder_v2_pr
    @thomasjpfan
    thomasjpfan committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    afc4223 View commit details
    Browse the repository at this point in the history

  8. Apply suggestions from code review 

    Co-authored-by: Andreas Mueller <t3kcit@gmail.com>
    @thomasjpfan @amueller
    thomasjpfan and amueller committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    6e4bf50 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2023

  1. DOC Only say classification

    @thomasjpfan
    thomasjpfan committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    d613c61 View commit details
    Browse the repository at this point in the history

  2. DOC Update examples and docstring

    @thomasjpfan
    thomasjpfan committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    ba85edb View commit details
    Browse the repository at this point in the history

  3. DOC Imrove example

    @thomasjpfan
    thomasjpfan committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    e3c8473 View commit details
    Browse the repository at this point in the history

  4. DOC Clarify fit_transform vs fit.transform

    @thomasjpfan
    thomasjpfan committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    0d6c4a2 View commit details
    Browse the repository at this point in the history

  5. CLN Address comments

    @thomasjpfan
    thomasjpfan committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    d9cd410 View commit details
    Browse the repository at this point in the history

  6. DOC Adds more code comments

    @thomasjpfan
    thomasjpfan committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    ee1e26b View commit details
    Browse the repository at this point in the history

  7. CLN Code formatting

    @thomasjpfan
    thomasjpfan committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    a399791 View commit details
    Browse the repository at this point in the history

  8. CLN Move test closer to comment

    @thomasjpfan
    thomasjpfan committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    fd2b963 View commit details
    Browse the repository at this point in the history

  9. DOC Adds more details aboue equations

    @thomasjpfan
    thomasjpfan committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    cd6c650 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2023

  1. Merge remote-tracking branch 'upstream/main' into target_regression_e… 

    …ncoder_v2_pr
    @thomasjpfan
    thomasjpfan committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    991fd9f View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2023

  1. CLN Address comments

    @thomasjpfan
    thomasjpfan committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    962125d View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2023

  1. TST Simplify test logic

    @thomasjpfan
    thomasjpfan committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    02d8346 View commit details
    Browse the repository at this point in the history

  2. CLN Address comments

    @thomasjpfan
    thomasjpfan committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    acb4b2e View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into target_regression_e… 

    …ncoder_v2_pr
    @thomasjpfan
    thomasjpfan committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    3261d10 View commit details
    Browse the repository at this point in the history

  4. DOC Adds note about type_of_target inference

    @thomasjpfan
    thomasjpfan committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    a57b117 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2023

  1. ENH Use integers for counts

    @thomasjpfan
    thomasjpfan committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    5a330be View commit details
    Browse the repository at this point in the history

  2. STY Formatting

    @thomasjpfan
    thomasjpfan committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    f1a14d7 View commit details
    Browse the repository at this point in the history

  3. STY Fix numpydoc linting error

    @thomasjpfan
    thomasjpfan committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    66fb8bd View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2023

  1. DOC Adds example about low and high smoothing parameters

    @thomasjpfan
    thomasjpfan committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    f5df8b8 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2023

  1. Merge remote-tracking branch 'upstream/main' into target_regression_e… 

    …ncoder_v2_pr
    @thomasjpfan
    thomasjpfan committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    906ac98 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
    @thomasjpfan @ogrisel
    thomasjpfan and ogrisel committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    43630cf View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2023

  1. STY Black formating

    @thomasjpfan
    thomasjpfan committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    177128d View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2023

  1. Merge remote-tracking branch 'upstream/main' into target_regression_e… 

    …ncoder_v2_pr
    @thomasjpfan
    thomasjpfan committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    e37b6ec View commit details
    Browse the repository at this point in the history

  2. DOC Adds mixed encoder for high and low cardinality

    @thomasjpfan
    thomasjpfan committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    86d357e View commit details
    Browse the repository at this point in the history

  3. DOC Address comments

    @thomasjpfan
    thomasjpfan committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    a7cc80f View commit details
    Browse the repository at this point in the history

  4. ENH Make sure the colors align between graphs

    @thomasjpfan
    thomasjpfan committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    0bcad5b View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
    @thomasjpfan @ogrisel
    thomasjpfan and ogrisel committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    61081db View commit details
    Browse the repository at this point in the history

  6. CLN Reformat section headers and move sections around

    @thomasjpfan
    thomasjpfan committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    2e4bd85 View commit details
    Browse the repository at this point in the history

  7. CLN Try to work around sphinx 4.0.1

    @thomasjpfan
    thomasjpfan committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    07a225c View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2023

  1. CLN Address comments

    @thomasjpfan
    thomasjpfan committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    7cd0c8d View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2023

  1. Merge remote-tracking branch 'upstream/main' into target_regression_e… 

    …ncoder_v2_pr
    @thomasjpfan
    thomasjpfan committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    94fd097 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2023

  1. CLN Better variable names

    @thomasjpfan
    thomasjpfan committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    56dd2fa View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into target_regression_e… 

    …ncoder_v2_pr
    @thomasjpfan
    thomasjpfan committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    317e13a View commit details
    Browse the repository at this point in the history

  3. ENH Restrict cv to integers

    @thomasjpfan
    thomasjpfan committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    c4eacfa View commit details
    Browse the repository at this point in the history

  4. DOC Improve docstring

    @thomasjpfan
    thomasjpfan committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    0ab474b View commit details
    Browse the repository at this point in the history

  5. CLN Better variable names in test

    @thomasjpfan
    thomasjpfan committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    c09556c View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
    @thomasjpfan @ogrisel
    thomasjpfan and ogrisel committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    b7654bb View commit details
    Browse the repository at this point in the history

  2. DOC Simplify notes

    @thomasjpfan
    thomasjpfan committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    387f42c View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2023

  1. DOC Adds diagram about cross validation

    @thomasjpfan
    thomasjpfan committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    efe630c View commit details
    Browse the repository at this point in the history

  2. DOC Explain fit vs fit_transform

    @thomasjpfan
    thomasjpfan committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    803a988 View commit details
    Browse the repository at this point in the history

  3. DOC Clarify fit

    @thomasjpfan
    thomasjpfan committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    f5f7ab1 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
    @thomasjpfan @ogrisel
    thomasjpfan and ogrisel committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    0e784b1 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into target_regression_e… 

    …ncoder_v2_pr
    @thomasjpfan
    thomasjpfan committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    444f589 View commit details
    Browse the repository at this point in the history

  3. FIX Fixes compile issue

    @thomasjpfan
    thomasjpfan committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    4994bc4 View commit details
    Browse the repository at this point in the history

  4. CLN Removes pow

    @thomasjpfan
    thomasjpfan committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    8fb1a11 View commit details
    Browse the repository at this point in the history

  5. CLN Use nogil and pointers

    @thomasjpfan
    thomasjpfan committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    850694e View commit details
    Browse the repository at this point in the history

  6. MNT Use vector instead

    @thomasjpfan
    thomasjpfan committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    665e2e9 View commit details
    Browse the repository at this point in the history

  7. DOC Adds note about missing values

    @thomasjpfan
    thomasjpfan committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    5247123 View commit details
    Browse the repository at this point in the history

  8. API Adds shuffle and random_state

    @thomasjpfan
    thomasjpfan committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    70f99fe View commit details
    Browse the repository at this point in the history

  9. STY Slight reformatting

    @thomasjpfan
    thomasjpfan committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    e09660c View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2023

  1. Check random seeds [all random seeds] 

    test_fit_transform_not_associated_withy_if_ordinal_categorical_is_not
    @thomasjpfan
    thomasjpfan committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    690fcdc View commit details
    Browse the repository at this point in the history

  2. API Change attriubte name to target_mean_

    @thomasjpfan
    thomasjpfan committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    a327b52 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Jovan Stojanovic <62058944+jovan-stojanovic@users.noreply.github.com>
    @thomasjpfan @jovan-stojanovic
    thomasjpfan and jovan-stojanovic committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    6b27afd View commit details
    Browse the repository at this point in the history

  4. STY Linting issue

    @thomasjpfan
    thomasjpfan committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    9773765 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'upstream/main' into target_regression_e… 

    …ncoder_v2_pr
    @thomasjpfan
    thomasjpfan committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    8e18746 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2023

  1. FIX Fixes edge case with smooth=0.0 and unknown categories in cv

    @thomasjpfan
    thomasjpfan committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    1ea0407 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
    @thomasjpfan @ogrisel
    thomasjpfan and ogrisel committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    df5574d View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into target_regression_e… 

    …ncoder_v2_pr
    @thomasjpfan
    thomasjpfan committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    d681e06 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2023

  1. TST Improves testing maintainability

    @thomasjpfan
    thomasjpfan committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    0b458c3 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2023

  1. TST add statistical-integration tests to check the benefit of interna… 

    …l CV
    @ogrisel
    ogrisel committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    26d2429 View commit details
    Browse the repository at this point in the history

  2. Fix comment in test to more accurately describe what's happening

    @ogrisel
    ogrisel committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    d77e519 View commit details
    Browse the repository at this point in the history

  3. TST Use RNG for permutation

    @thomasjpfan
    thomasjpfan committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    05997bb View commit details
    Browse the repository at this point in the history

  4. More fixes in inline comments for the new test

    @ogrisel
    ogrisel committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    6377419 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2023

  1. Use pandas to parse the fetched the example dataset. 

    Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
    @ogrisel @glemaitre
    ogrisel and glemaitre committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    180ee0e View commit details
    Browse the repository at this point in the history