Add PreSpecified(Vec<u8>) option to KeyIdMethod. #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
est31
approved these changes
Dec 6, 2023
djc
approved these changes
Dec 7, 2023
cpu
reviewed
Dec 7, 2023
brocaar
force-pushed
the
fix_issue_195_take_2
branch
from
6c2f542
to
5b81bde
Compare
|
I've implemented all feedback and all tests are green :) Thanks for helping me with resolving this issue and reviewing this pull-request. Your feedback was really helpful and I learned a few new things! Once merged, would it be possible to push a new release containing this fix? |
cpu
approved these changes
Dec 8, 2023
cpu
force-pushed
the
fix_issue_195_take_2
branch
from
5b81bde
to
6b784a1
Compare
If using from_ca_cert_der/_pem, the key_identifier_method would always be set to Sha256, which is not always true. If using OpenSSL for example SHA1 would be used. If the provided CA certificate contains a SubjectKeyIdentifier extension, then this option will be automatically set. Fixes rustls#195.
cpu
force-pushed
the
fix_issue_195_take_2
branch
from
6b784a1
to
b14393e
Compare
|
I updated the branch to address my tiny review nit and to rebase on main. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If using from_ca_cert_der/_pem, the key_identifier_method would always be set to Sha256, which is not always true. If using OpenSSL for example SHA1 would be used.
If the provided CA certificate contains a SubjectKeyIdentifier extension, then this option will be automatically set.
Fixes #195.