Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.12.0 #202

Merged
merged 3 commits into from
Dec 16, 2023
Merged

Release 0.12.0 #202

merged 3 commits into from
Dec 16, 2023

Conversation

est31
Copy link
Member

@est31 est31 commented Dec 16, 2023

For release notes see the changelog.

fixes #199

@est31 est31 mentioned this pull request Dec 16, 2023
4 tasks
@est31 est31 requested review from djc and cpu December 16, 2023 00:15
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together 👍

rcgen/CHANGELOG.md Show resolved Hide resolved
rcgen/CHANGELOG.md Outdated Show resolved Hide resolved
rcgen/CHANGELOG.md Outdated Show resolved Hide resolved
est31 and others added 2 commits December 16, 2023 22:28
Co-authored-by: Daniel McCarney <daniel@binaryparadox.net>
@est31
Copy link
Member Author

est31 commented Dec 16, 2023

There is no changes to the version in Cargo.toml in this PR. I suppose #183 had to increase it due to the breaking changes. Maybe we should switch to 0.13.0-dev after this PR?

@est31 est31 merged commit d382a37 into main Dec 16, 2023
32 checks passed
@est31 est31 deleted the release-0.12.0 branch December 16, 2023 21:55
@cpu
Copy link
Member

cpu commented Dec 18, 2023

As a small note, in the future I'd like a chance to approve the changelog before the release is published if I leave feedback. If I don't reply right away it seems reasonable to roll forward without waiting.

Maybe we should switch to 0.13.0-dev after this PR?

That sounds fine to me. In the other Rustls repos we tend to use -alpha.0 but I don't feel strongly.

@est31
Copy link
Member Author

est31 commented Dec 18, 2023

I'd like a chance to approve the changelog before the release is published if I leave feedback

Sorry, noted!

github-merge-queue bot pushed a commit that referenced this pull request Jan 12, 2024
From the release 0.12 of rcgen #202
, we must now choose `ring` or `aws_lc_rc` as a feature.
Because `rustls_cert_gen` has `default-features = false`, its build is
currently broken.

This PR activate `aws_lc_rc` feature, because soon it will get RSA key
generation support aws/aws-lc-rs#296 , so it
will provide more options.

But we could also change it to default to whatever `rcgen` default or
use `ring` as default depending on your preferences.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.12.0 release planning
2 participants