Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Expose set_wal_compression_type #817

Merged
merged 2 commits into from Nov 27, 2023
Merged

feat: Expose set_wal_compression_type #817

merged 2 commits into from Nov 27, 2023

Conversation

ovr
Copy link
Contributor

@ovr ovr commented Sep 14, 2023

Hello!

Fix #778

Thanks

stanislav-tkach
stanislav-tkach approved these changes Sep 14, 2023
View reviewed changes
tests/test_rocksdb_options.rs Outdated Show resolved Hide resolved
@aleksuss
Copy link
Member

@ovr, please add a test or extend existing where you pass DBCompressionType::Lz4 and, namely, unsupported compression type.

@ovr ovr force-pushed the feat/expose-wal-compression branch from 87c738a to 5232920 Compare November 13, 2023 10:30
@ovr
Copy link
Contributor Author

ovr commented Nov 13, 2023

I have rebased and updated it to reflect review comments.

Thanks

@aleksuss aleksuss enabled auto-merge (squash) November 27, 2023 10:03
@aleksuss aleksuss merged commit b30f165 into rust-rocksdb:master Nov 27, 2023
7 checks passed
zaidoon1 pushed a commit to zaidoon1/rust-speedb that referenced this pull request Feb 19, 2024
@ovr
feat: Expose set_wal_compression_type (rust-rocksdb#817)
b7e49cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksuss aleksuss aleksuss approved these changes

@stanislav-tkach stanislav-tkach stanislav-tkach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please add Options::set_wal_compression()
3 participants
@ovr @aleksuss @stanislav-tkach