chore: check in runtime

rust-rocksdb · Nov 13, 2023 · 5232920 · 5232920
1 parent b5c305a
commit 5232920
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 3 deletions.
diff --git a/src/db_options.rs b/src/db_options.rs
@@ -1078,10 +1078,15 @@ impl Options {
     ///
     /// let mut opts = Options::default();
     /// opts.set_wal_compression_type(DBCompressionType::Zstd);
+    /// // Or None to disable it
+    /// opts.set_wal_compression_type(DBCompressionType::None);
     /// ```
     pub fn set_wal_compression_type(&mut self, t: DBCompressionType) {
-        unsafe {
-            ffi::rocksdb_options_set_wal_compression(self.inner, t as c_int);
+        match t {
+            DBCompressionType::None | DBCompressionType::Zstd => unsafe {
+                ffi::rocksdb_options_set_wal_compression(self.inner, t as c_int);
+            },
+            other => unimplemented!("{:?} is not supported for WAL compression", other),
         }
     }
 

diff --git a/tests/test_rocksdb_options.rs b/tests/test_rocksdb_options.rs
@@ -172,17 +172,27 @@ fn set_compression_options_zstd_max_train_bytes() {
 }
 
 #[test]
-#[cfg(feature = "zstd")]
 fn set_wal_compression_zstd() {
     let path = DBPath::new("_set_wal_compression_zstd");
     {
         let mut opts = Options::default();
         opts.create_if_missing(true);
+        opts.set_wal_compression_type(DBCompressionType::None);
         opts.set_wal_compression_type(DBCompressionType::Zstd);
         let _db = DB::open(&opts, &path).unwrap();
     }
 }
 
+#[test]
+#[should_panic(expected = "Lz4 is not supported for WAL compression")]
+fn set_wal_compression_unsupported() {
+    {
+        let mut opts = Options::default();
+        opts.create_if_missing(true);
+        opts.set_wal_compression_type(DBCompressionType::Lz4);
+    }
+}
+
 fn test_compression_type(ty: DBCompressionType) {
     let path = DBPath::new("_test_compression_type");