Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update snappy to 1.1.10 #788

Merged
merged 1 commit into from Jun 5, 2023

Conversation

timsueberkrueb
Copy link
Contributor

snappy 1.1.10 includes "compilation fixes for various environments". In particular, it fixes compilation on older systems like Debian Buster, which previously failed due to snappy relying on the =@ccz assembly constraint, which is not supported in clang 7 which ships with Debian Buster:

  running: "c++" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-m64" "-I" "snappy/" "-I" "." "-Wall" "-std=c++11" "-DNDEBUG=1" "-o" "/__w/qdrant/qdrant/target/x86_64-unknown-linux-gnu/release/build/librocksdb-sys-906afbc25bf7847d/out/snappy/snappy-c.o" "-c" "snappy/snappy-c.cc"
  exit status: 0
  cargo:warning=snappy/snappy.cc:1033:36: error: invalid output constraint '=@ccz' in asm
  cargo:warning=      : [tag_type] "+r"(tag_type), "=@ccz"(is_literal));
  cargo:warning=                                   ^
  cargo:warning=1 error generated.
  exit status: 1

Updating snappy to 1.1.10 is sufficient to make the compilation succeed on Debian Buster.

@aleksuss aleksuss merged commit bcf5667 into rust-rocksdb:master Jun 5, 2023
7 checks passed
Shylock-Hg pushed a commit to Shylock-Hg/rust-rocksdb that referenced this pull request Mar 29, 2024
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants