Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for older GLIBC version in binary releases #1978

Closed
generall opened this issue May 25, 2023 · 2 comments
Closed

Support for older GLIBC version in binary releases #1978

generall opened this issue May 25, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@generall
Copy link
Member

Is your feature request related to a problem? Please describe.

wget -c  https://github.com/qdrant/qdrant/releases/download/v1.2.0/qdrant-x86_64-unknown-linux-gnu.tar.gz -O - | tar -xz

./qdrant --help

./qdrant: /lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.29' not found (required by ./qdrant)
./qdrant: /lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.30' not found (required by ./qdrant)
./qdrant: /lib/x86_64-linux-gnu/libstdc++.so.6: version `CXXABI_1.3.13' not found (required by ./qdrant)
./qdrant: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by ./qdrant)
./qdrant: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by ./qdrant)
./qdrant: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by ./qdrant)

on

FROM nvcr.io/nvidia/pytorch:21.10-py3

Which is Ubuntu (20.4)

Describe the solution you'd like
Make binary builds work on different systems.

@timsueberkrueb
Copy link
Contributor

timsueberkrueb commented Jun 1, 2023

A small report on this one: I attempted to build qdrant on debian:buster, but unfortunately that doesn't seem to be possible at the moment due to snappy relying on the =@ccz assembly constraint, which is not supported in clang 7 that ships with Debian Buster:

  running: "c++" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-m64" "-I" "snappy/" "-I" "." "-Wall" "-std=c++11" "-DNDEBUG=1" "-o" "/__w/qdrant/qdrant/target/x86_64-unknown-linux-gnu/release/build/librocksdb-sys-906afbc25bf7847d/out/snappy/snappy-c.o" "-c" "snappy/snappy-c.cc"
  exit status: 0
  cargo:warning=snappy/snappy.cc:1033:36: error: invalid output constraint '=@ccz' in asm
  cargo:warning=      : [tag_type] "+r"(tag_type), "=@ccz"(is_literal));
  cargo:warning=                                   ^
  cargo:warning=1 error generated.
  exit status: 1

This seems to have been fixed in google/snappy@8dd58a5. This would require rust-rocksdb to update snappy to 1.1.10, which is currently at v1.1.9 (google/snappy@2b63814).

Created a PR to request updating snappy: rust-rocksdb/rust-rocksdb#788.

@agourlay agourlay added the enhancement New feature or request label Aug 31, 2023
@generall
Copy link
Member Author

Resolved by introducing MUSL builds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants