feat(download): reflect the download/TLS backends in the user agent #3815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3790.
https://www.reddit.com/r/rust/comments/1cmzxeu/call_for_testing_rustups_reqwest_backend_with/l357qz1 suggests that we could make UAs more detailed to perform some sort of telemetry-based analysis on the download/TLS backend segmentation.
I just got the confirmation from @Mark-Simulacrum that they can obtain a certain amount of user agent strings for the analysis.
We should've done this sooner (ideally before v1.27.1), but since we've missed the window, the current plan would be looking at how many have switched to
RUSTUP_USE_RUSTLS=0when it gets shipped.