Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify download and/or TLS backends #3790

Open
3 of 6 tasks
rami3l opened this issue Apr 26, 2024 · 1 comment
Open
3 of 6 tasks

Simplify download and/or TLS backends #3790

rami3l opened this issue Apr 26, 2024 · 1 comment
Labels
enhancement meta This issue is related to project management. tracking This is a tracking issue
Milestone

Comments

@rami3l
Copy link
Member

rami3l commented Apr 26, 2024

Part of #1611.

Motivation

The direct motivation of this change is to simplify Rustup's building process in order to make Rustup more cross-build friendly and prevent surprise stable-only CI build errors like the ones we've encountered while bumping OpenSSL to v3, i.e. #3478, #3668, etc.

Status quo

  • The default currently is to use reqwest with native-tls (OpenSSL on Linux, native stacks on macOS and Windows)
  • If RUSTUP_USE_CURL is set, we use the curl backend, which defaults to openssl
  • If RUSTUP_USE_RUSTLS is set, we use reqwest with rustls

#3788 (comment)

Goal

The eventual goal would be removing RUSTUP_USE_CURL and/or RUSTUP_USE_RUSTLS, leaving a single stack "in favor of maximally-Rust solutions", while "making sure we minimize the risk of getting users stuck".

#3788 (comment)

Plan

  • Unfreeze OpenSSL so we can keep it updated again
  • Include tracing support with tracing-subscriber by default
    • Make sure we don't constrain the trace!() level statically
    • Maybe remove opentelemetry stuff
  • Switch the default from reqwest/native-tls to reqwest/rustls, keeping the curl/openssl fallback for now
  • Collect user feedback
  • Remove curl/openssl and reqwest/native-tls, leaving only reqwest/rustls

#3788 (comment)

@rami3l rami3l added enhancement tracking This is a tracking issue meta This issue is related to project management. labels Apr 26, 2024
@rami3l rami3l added this to the On Deck milestone Apr 26, 2024
@rami3l rami3l modified the milestones: On Deck, 1.29.0 Apr 26, 2024
@djc
Copy link
Contributor

djc commented Apr 26, 2024

Also, many benefits from rustls just being more secure by default than OpenSSL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement meta This issue is related to project management. tracking This is a tracking issue
Projects
None yet
Development

No branches or pull requests

2 participants